mirror of https://github.com/openclaw/openclaw.git
489 lines
14 KiB
TypeScript
489 lines
14 KiB
TypeScript
import { afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import type { SecretInput } from "../config/types.secrets.js";
|
|
|
|
vi.mock("../infra/device-bootstrap.js", () => ({
|
|
issueDeviceBootstrapToken: vi.fn(async () => ({
|
|
token: "bootstrap-123",
|
|
expiresAtMs: 123,
|
|
})),
|
|
}));
|
|
|
|
let encodePairingSetupCode: typeof import("./setup-code.js").encodePairingSetupCode;
|
|
let resolvePairingSetupFromConfig: typeof import("./setup-code.js").resolvePairingSetupFromConfig;
|
|
let issueDeviceBootstrapTokenMock: typeof import("../infra/device-bootstrap.js").issueDeviceBootstrapToken;
|
|
|
|
describe("pairing setup code", () => {
|
|
type ResolvedSetup = Awaited<ReturnType<typeof resolvePairingSetupFromConfig>>;
|
|
type ResolveSetupConfig = Parameters<typeof resolvePairingSetupFromConfig>[0];
|
|
type ResolveSetupOptions = Parameters<typeof resolvePairingSetupFromConfig>[1];
|
|
type ResolveSetupEnv = NonNullable<ResolveSetupOptions>["env"];
|
|
const defaultEnvSecretProviderConfig = {
|
|
secrets: {
|
|
providers: {
|
|
default: { source: "env" },
|
|
},
|
|
},
|
|
} as const;
|
|
const gatewayPasswordSecretRef: SecretInput = {
|
|
source: "env",
|
|
provider: "default",
|
|
id: "GW_PASSWORD",
|
|
};
|
|
const missingGatewayTokenSecretRef: SecretInput = {
|
|
source: "env",
|
|
provider: "default",
|
|
id: "MISSING_GW_TOKEN",
|
|
};
|
|
|
|
function createCustomGatewayConfig(
|
|
auth: NonNullable<ResolveSetupConfig["gateway"]>["auth"],
|
|
config: Omit<ResolveSetupConfig, "gateway"> = {},
|
|
): ResolveSetupConfig {
|
|
return {
|
|
...config,
|
|
gateway: {
|
|
bind: "custom",
|
|
customBindHost: "gateway.local",
|
|
auth,
|
|
},
|
|
};
|
|
}
|
|
|
|
function createTailnetDnsRunner() {
|
|
return vi.fn(async () => ({
|
|
code: 0,
|
|
stdout: '{"Self":{"DNSName":"mb-server.tailnet.ts.net."}}',
|
|
stderr: "",
|
|
}));
|
|
}
|
|
|
|
function expectResolvedSetupOk(
|
|
resolved: ResolvedSetup,
|
|
params: {
|
|
authLabel: string;
|
|
url?: string;
|
|
urlSource?: string;
|
|
},
|
|
) {
|
|
expect(resolved.ok).toBe(true);
|
|
if (!resolved.ok) {
|
|
throw new Error("expected setup resolution to succeed");
|
|
}
|
|
expect(resolved.authLabel).toBe(params.authLabel);
|
|
expect(resolved.payload.bootstrapToken).toBe("bootstrap-123");
|
|
expect(issueDeviceBootstrapTokenMock).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
profile: {
|
|
roles: ["node", "operator"],
|
|
scopes: ["operator.read", "operator.talk.secrets", "operator.write"],
|
|
},
|
|
}),
|
|
);
|
|
if (params.url) {
|
|
expect(resolved.payload.url).toBe(params.url);
|
|
}
|
|
if (params.urlSource) {
|
|
expect(resolved.urlSource).toBe(params.urlSource);
|
|
}
|
|
}
|
|
|
|
function expectResolvedSetupError(resolved: ResolvedSetup, snippet: string) {
|
|
expect(resolved.ok).toBe(false);
|
|
if (resolved.ok) {
|
|
throw new Error("expected setup resolution to fail");
|
|
}
|
|
expect(resolved.error).toContain(snippet);
|
|
}
|
|
|
|
async function expectResolvedSetupSuccessCase(params: {
|
|
config: ResolveSetupConfig;
|
|
options?: ResolveSetupOptions;
|
|
expected: {
|
|
authLabel: string;
|
|
url: string;
|
|
urlSource: string;
|
|
};
|
|
runCommandWithTimeout?: ReturnType<typeof vi.fn>;
|
|
expectedRunCommandCalls?: number;
|
|
}) {
|
|
const resolved = await resolvePairingSetupFromConfig(params.config, params.options);
|
|
expectResolvedSetupOk(resolved, params.expected);
|
|
if (params.runCommandWithTimeout) {
|
|
expect(params.runCommandWithTimeout).toHaveBeenCalledTimes(
|
|
params.expectedRunCommandCalls ?? 0,
|
|
);
|
|
}
|
|
}
|
|
|
|
async function expectResolvedSetupFailureCase(params: {
|
|
config: ResolveSetupConfig;
|
|
options?: ResolveSetupOptions;
|
|
expectedError: string;
|
|
}) {
|
|
try {
|
|
const resolved = await resolvePairingSetupFromConfig(params.config, params.options);
|
|
expectResolvedSetupError(resolved, params.expectedError);
|
|
} catch (error) {
|
|
expect(String(error)).toContain(params.expectedError);
|
|
}
|
|
}
|
|
|
|
async function expectResolveCustomGatewayRejects(params: {
|
|
auth: NonNullable<ResolveSetupConfig["gateway"]>["auth"];
|
|
env?: ResolveSetupEnv;
|
|
config?: Omit<ResolveSetupConfig, "gateway">;
|
|
expectedError: RegExp | string;
|
|
}) {
|
|
await expect(
|
|
resolveCustomGatewaySetup({
|
|
auth: params.auth,
|
|
env: params.env,
|
|
config: params.config,
|
|
}),
|
|
).rejects.toThrow(params.expectedError);
|
|
}
|
|
|
|
async function expectResolvedCustomGatewaySetupOk(params: {
|
|
auth: NonNullable<ResolveSetupConfig["gateway"]>["auth"];
|
|
env?: ResolveSetupEnv;
|
|
config?: Omit<ResolveSetupConfig, "gateway">;
|
|
expectedAuthLabel: string;
|
|
}) {
|
|
const resolved = await resolveCustomGatewaySetup({
|
|
auth: params.auth,
|
|
env: params.env,
|
|
config: params.config,
|
|
});
|
|
expectResolvedSetupOk(resolved, { authLabel: params.expectedAuthLabel });
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.stubEnv("OPENCLAW_GATEWAY_TOKEN", "");
|
|
vi.stubEnv("OPENCLAW_GATEWAY_PASSWORD", "");
|
|
vi.stubEnv("OPENCLAW_GATEWAY_PORT", "");
|
|
});
|
|
|
|
beforeAll(async () => {
|
|
({ encodePairingSetupCode, resolvePairingSetupFromConfig } = await import("./setup-code.js"));
|
|
({ issueDeviceBootstrapToken: issueDeviceBootstrapTokenMock } =
|
|
await import("../infra/device-bootstrap.js"));
|
|
});
|
|
|
|
beforeEach(() => {
|
|
vi.mocked(issueDeviceBootstrapTokenMock).mockClear();
|
|
});
|
|
|
|
afterEach(() => {
|
|
vi.unstubAllEnvs();
|
|
});
|
|
|
|
it.each([
|
|
{
|
|
name: "encodes payload as base64url JSON",
|
|
payload: {
|
|
url: "wss://gateway.example.com:443",
|
|
bootstrapToken: "abc",
|
|
},
|
|
expected:
|
|
"eyJ1cmwiOiJ3c3M6Ly9nYXRld2F5LmV4YW1wbGUuY29tOjQ0MyIsImJvb3RzdHJhcFRva2VuIjoiYWJjIn0",
|
|
},
|
|
] as const)("$name", ({ payload, expected }) => {
|
|
expect(encodePairingSetupCode(payload)).toBe(expected);
|
|
});
|
|
|
|
async function resolveCustomGatewaySetup(params: {
|
|
auth: NonNullable<ResolveSetupConfig["gateway"]>["auth"];
|
|
env?: ResolveSetupEnv;
|
|
config?: Omit<ResolveSetupConfig, "gateway">;
|
|
}) {
|
|
return await resolvePairingSetupFromConfig(
|
|
createCustomGatewayConfig(params.auth, params.config),
|
|
{
|
|
env: params.env ?? {},
|
|
},
|
|
);
|
|
}
|
|
|
|
it.each([
|
|
{
|
|
name: "resolves gateway.auth.password SecretRef for pairing payload",
|
|
auth: {
|
|
mode: "password",
|
|
password: gatewayPasswordSecretRef,
|
|
} as const,
|
|
env: {
|
|
GW_PASSWORD: "resolved-password", // pragma: allowlist secret
|
|
},
|
|
expectedAuthLabel: "password",
|
|
},
|
|
{
|
|
name: "uses OPENCLAW_GATEWAY_PASSWORD without resolving configured password SecretRef",
|
|
auth: {
|
|
mode: "password",
|
|
password: { source: "env", provider: "default", id: "MISSING_GW_PASSWORD" },
|
|
} as const,
|
|
env: {
|
|
OPENCLAW_GATEWAY_PASSWORD: "password-from-env", // pragma: allowlist secret
|
|
},
|
|
expectedAuthLabel: "password",
|
|
},
|
|
{
|
|
name: "does not resolve gateway.auth.password SecretRef in token mode",
|
|
auth: {
|
|
mode: "token",
|
|
token: "tok_123",
|
|
password: { source: "env", provider: "missing", id: "GW_PASSWORD" },
|
|
} as const,
|
|
env: {},
|
|
expectedAuthLabel: "token",
|
|
},
|
|
{
|
|
name: "resolves gateway.auth.token SecretRef for pairing payload",
|
|
auth: {
|
|
mode: "token",
|
|
token: { source: "env", provider: "default", id: "GW_TOKEN" },
|
|
} as const,
|
|
env: {
|
|
GW_TOKEN: "resolved-token",
|
|
},
|
|
expectedAuthLabel: "token",
|
|
},
|
|
] as const)("$name", async ({ auth, env, expectedAuthLabel }) => {
|
|
await expectResolvedCustomGatewaySetupOk({
|
|
auth,
|
|
env,
|
|
config: defaultEnvSecretProviderConfig,
|
|
expectedAuthLabel,
|
|
});
|
|
});
|
|
|
|
it.each([
|
|
{
|
|
name: "errors when gateway.auth.token SecretRef is unresolved in token mode",
|
|
config: createCustomGatewayConfig(
|
|
{
|
|
mode: "token",
|
|
token: missingGatewayTokenSecretRef,
|
|
},
|
|
defaultEnvSecretProviderConfig,
|
|
),
|
|
options: { env: {} },
|
|
expectedError: "MISSING_GW_TOKEN",
|
|
},
|
|
] as const)("$name", async ({ config, options, expectedError }) => {
|
|
await expectResolvedSetupFailureCase({ config, options, expectedError });
|
|
});
|
|
|
|
async function resolveInferredModeWithPasswordEnv(token: SecretInput) {
|
|
return await resolvePairingSetupFromConfig(
|
|
{
|
|
gateway: {
|
|
bind: "custom",
|
|
customBindHost: "gateway.local",
|
|
auth: { token },
|
|
},
|
|
...defaultEnvSecretProviderConfig,
|
|
},
|
|
{
|
|
env: {
|
|
OPENCLAW_GATEWAY_PASSWORD: "password-from-env", // pragma: allowlist secret
|
|
},
|
|
},
|
|
);
|
|
}
|
|
|
|
async function expectInferredPasswordEnvSetupCase(token: SecretInput) {
|
|
const resolved = await resolveInferredModeWithPasswordEnv(token);
|
|
expectResolvedSetupOk(resolved, { authLabel: "password" });
|
|
}
|
|
|
|
it.each([
|
|
{
|
|
name: "uses password env in inferred mode without resolving token SecretRef",
|
|
token: {
|
|
source: "env",
|
|
provider: "default",
|
|
id: "MISSING_GW_TOKEN",
|
|
} satisfies SecretInput,
|
|
},
|
|
{
|
|
name: "does not treat env-template token as plaintext in inferred mode",
|
|
token: "${MISSING_GW_TOKEN}",
|
|
},
|
|
] as const)("$name", async ({ token }) => {
|
|
await expectInferredPasswordEnvSetupCase(token);
|
|
});
|
|
|
|
it.each([
|
|
{
|
|
name: "requires explicit auth mode when token and password are both configured",
|
|
auth: {
|
|
token: { source: "env", provider: "default", id: "GW_TOKEN" },
|
|
password: gatewayPasswordSecretRef,
|
|
} as const,
|
|
env: {
|
|
GW_TOKEN: "resolved-token",
|
|
GW_PASSWORD: "resolved-password", // pragma: allowlist secret
|
|
},
|
|
},
|
|
{
|
|
name: "errors when token and password SecretRefs are both configured with inferred mode",
|
|
auth: {
|
|
token: missingGatewayTokenSecretRef,
|
|
password: gatewayPasswordSecretRef,
|
|
} as const,
|
|
env: {
|
|
GW_PASSWORD: "resolved-password", // pragma: allowlist secret
|
|
},
|
|
},
|
|
] as const)("$name", async ({ auth, env }) => {
|
|
await expectResolveCustomGatewayRejects({
|
|
auth,
|
|
env,
|
|
config: defaultEnvSecretProviderConfig,
|
|
expectedError: /gateway\.auth\.mode is unset/i,
|
|
});
|
|
});
|
|
|
|
it.each([
|
|
{
|
|
name: "resolves custom bind + token auth",
|
|
config: {
|
|
gateway: {
|
|
bind: "custom",
|
|
customBindHost: "gateway.local",
|
|
port: 19001,
|
|
auth: { mode: "token", token: "tok_123" },
|
|
},
|
|
} satisfies ResolveSetupConfig,
|
|
expected: {
|
|
authLabel: "token",
|
|
url: "ws://gateway.local:19001",
|
|
urlSource: "gateway.bind=custom",
|
|
},
|
|
},
|
|
{
|
|
name: "honors env token override",
|
|
config: {
|
|
gateway: {
|
|
bind: "custom",
|
|
customBindHost: "gateway.local",
|
|
auth: { mode: "token", token: "old" },
|
|
},
|
|
} satisfies ResolveSetupConfig,
|
|
options: {
|
|
env: {
|
|
OPENCLAW_GATEWAY_TOKEN: "new-token",
|
|
},
|
|
} satisfies ResolveSetupOptions,
|
|
expected: {
|
|
authLabel: "token",
|
|
url: "ws://gateway.local:18789",
|
|
urlSource: "gateway.bind=custom",
|
|
},
|
|
},
|
|
] as const)("$name", async ({ config, options, expected }) => {
|
|
await expectResolvedSetupSuccessCase({
|
|
config,
|
|
options,
|
|
expected,
|
|
});
|
|
});
|
|
|
|
it.each([
|
|
{
|
|
name: "errors when gateway is loopback only",
|
|
config: {
|
|
gateway: {
|
|
bind: "loopback",
|
|
auth: { mode: "token", token: "tok" },
|
|
},
|
|
} satisfies ResolveSetupConfig,
|
|
expectedError: "only bound to loopback",
|
|
},
|
|
{
|
|
name: "returns a bind-specific error when interface discovery throws",
|
|
config: {
|
|
gateway: {
|
|
bind: "lan",
|
|
auth: { mode: "token", token: "tok" },
|
|
},
|
|
} satisfies ResolveSetupConfig,
|
|
options: {
|
|
networkInterfaces: () => {
|
|
throw new Error("uv_interface_addresses failed");
|
|
},
|
|
} satisfies ResolveSetupOptions,
|
|
expectedError: "gateway.bind=lan set, but no private LAN IP was found.",
|
|
},
|
|
] as const)("$name", async ({ config, options, expectedError }) => {
|
|
await expectResolvedSetupFailureCase({
|
|
config,
|
|
options,
|
|
expectedError,
|
|
});
|
|
});
|
|
|
|
it.each([
|
|
{
|
|
name: "uses tailscale serve DNS when available",
|
|
createOptions: () => {
|
|
const runCommandWithTimeout = createTailnetDnsRunner();
|
|
return {
|
|
options: {
|
|
runCommandWithTimeout,
|
|
} satisfies ResolveSetupOptions,
|
|
runCommandWithTimeout,
|
|
expectedRunCommandCalls: 1,
|
|
};
|
|
},
|
|
config: {
|
|
gateway: {
|
|
tailscale: { mode: "serve" },
|
|
auth: { mode: "password", password: "secret" },
|
|
},
|
|
} satisfies ResolveSetupConfig,
|
|
expected: {
|
|
authLabel: "password",
|
|
url: "wss://mb-server.tailnet.ts.net",
|
|
urlSource: "gateway.tailscale.mode=serve",
|
|
},
|
|
},
|
|
{
|
|
name: "prefers gateway.remote.url over tailscale when requested",
|
|
createOptions: () => {
|
|
const runCommandWithTimeout = createTailnetDnsRunner();
|
|
return {
|
|
options: {
|
|
preferRemoteUrl: true,
|
|
runCommandWithTimeout,
|
|
} satisfies ResolveSetupOptions,
|
|
runCommandWithTimeout,
|
|
expectedRunCommandCalls: 0,
|
|
};
|
|
},
|
|
config: {
|
|
gateway: {
|
|
tailscale: { mode: "serve" },
|
|
remote: { url: "wss://remote.example.com:444" },
|
|
auth: { mode: "token", token: "tok_123" },
|
|
},
|
|
} satisfies ResolveSetupConfig,
|
|
expected: {
|
|
authLabel: "token",
|
|
url: "wss://remote.example.com:444",
|
|
urlSource: "gateway.remote.url",
|
|
},
|
|
},
|
|
] as const)("$name", async ({ config, createOptions, expected }) => {
|
|
const { options, runCommandWithTimeout, expectedRunCommandCalls } = createOptions();
|
|
await expectResolvedSetupSuccessCase({
|
|
config,
|
|
options,
|
|
expected,
|
|
runCommandWithTimeout,
|
|
expectedRunCommandCalls,
|
|
});
|
|
});
|
|
});
|