mirror of https://github.com/openclaw/openclaw.git
b29e180ef4
* fix(imessage): prevent self-chat dedupe false positives (#47830) Move echo cache remember() to post-send only, add early return when inbound message ID doesn't match cached IDs (prevents text-based false positives in self-chat), and reduce text TTL from 5s to 3s. Three targeted changes to fix silent user message loss in self-chat: 1. deliver.ts: Remove pre-send remember() call — cache only reflects successfully-delivered content, not pre-send full text. 2. echo-cache.ts: Skip text fallback when inbound has a valid message ID that doesn't match any cached outbound ID. In self-chat, sender == target so scopes collide; a user message with a fresh ID but matching text was incorrectly dropped as an echo. 3. echo-cache.ts: Reduce text TTL from 5000ms to 3000ms — agent echoes arrive within 1-2s, 5s was too wide. Adds self-chat-dedupe.test.ts (7 tests) + updates deliver.test.ts. BlueBubbles uses a different cache pattern — no changes needed there. Closes #47830 * review(imessage): strip debug logs, bump echo TTL to 4s (#47830) Bruce Phase 4 review changes: - Remove all [IMSG-DEBUG] console.error calls from inbound-processing.ts and monitor-provider.ts (23 lines, left over from Phase 2 debug deploy) - Bump SENT_MESSAGE_TEXT_TTL_MS from 3s to 4s in echo-cache.ts to give ~2s margin above the observed 2.2s echo arrival time under load - Update TTL tests to reflect 4s TTL (expired at 5s, live at 3s) * fix(imessage): add dedupe comments and canary/compat/TTL tests * fix(imessage): address review feedback on echo cache, shadowing, and test IDs * refactor(imessage): hoist inboundMessageId to eliminate duplicate computation (#47830) * fix(imessage): unify self-chat echo matching * fix: use inbound guid for self-chat echo matching (#55359) (thanks @rmarr) --------- Co-authored-by: Rohan Marr <rmarr@users.noreply.github.com> Co-authored-by: Ayaan Zaidi <hi@obviy.us> |
||
|---|---|---|
| .. | ||
| monitor | ||
| accounts.ts | ||
| channel.outbound.test.ts | ||
| channel.runtime.ts | ||
| channel.setup.ts | ||
| channel.ts | ||
| client.ts | ||
| config-schema.ts | ||
| config-ui-hints.ts | ||
| constants.ts | ||
| conversation-bindings.ts | ||
| conversation-id.ts | ||
| conversation-route.test.ts | ||
| conversation-route.ts | ||
| group-policy.contract.test.ts | ||
| group-policy.ts | ||
| monitor.gating.test.ts | ||
| monitor.shutdown.unhandled-rejection.test.ts | ||
| monitor.ts | ||
| outbound-adapter.ts | ||
| outbound-payload.contract.test.ts | ||
| plugin-shared.ts | ||
| plugins-core.contract.test.ts | ||
| probe.ts | ||
| registry-backed.contract.test.ts | ||
| runtime.ts | ||
| send.ts | ||
| setup-core.ts | ||
| setup-surface.ts | ||
| shared.ts | ||
| target-parsing-helpers.ts | ||
| targets.test.ts | ||
| targets.ts | ||