nyrn
/
openclaw
mirror of https://github.com/openclaw/openclaw.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
openclaw/src/gateway
History
Liu Yuan 97b3ee7ec0 Fix: Honor `/think off` for reasoning-capable models 
Problem:
When users execute `/think off`, they still receive `reasoning_content`
from models configured with `reasoning: true` (e.g., GLM-4.7, GLM-4.6,
Kimi K2.5, MiniMax-M2.1).

Expected: `/think off` should completely disable reasoning content.
Actual: Reasoning content is still returned.

Root Cause:
The directive handlers delete `sessionEntry.thinkingLevel` when user
executes `/think off`. This causes the thinking level to become undefined,
and the system falls back to `resolveThinkingDefault()`, which checks the
model catalog and returns "low" for reasoning-capable models, ignoring the
user's explicit intent.

Why We Must Persist "off" (Design Rationale):

1. **Model-dependent defaults**: Unlike other directives where "off" means
   use a global default, `thinkingLevel` has model-dependent defaults:
   - Reasoning-capable models (GLM-4.7, etc.) → default "low"
   - Other models → default "off"

2. **Existing pattern**: The codebase already follows this pattern for
   `elevatedLevel`, which persists "off" explicitly to override defaults
   that may be "on". The comment explains:
   "Persist 'off' explicitly so `/elevated off` actually overrides defaults."

3. **User intent**: When a user explicitly executes `/think off`, they want
   to disable thinking regardless of the model's capabilities. Deleting the
   field breaks this intent by falling back to the model's default.

Solution:
Persist "off" value instead of deleting the field in all internal directive handlers:
- `src/auto-reply/reply/directive-handling.impl.ts`: Directive-only messages
- `src/auto-reply/reply/directive-handling.persist.ts`: Inline directives
- `src/commands/agent.ts`: CLI command-line flags

Gateway API Backward Compatibility:
The original implementation incorrectly mapped `null` to "off" in
`sessions-patch.ts` for consistency with internal handlers. This was a
breaking change because:
- Previously, `null` cleared the override (deleted the field)
- API clients lost the ability to "clear to default" via `null`
- This contradicts standard JSON semantics where `null` means "no value"

Restored original null semantics in `src/gateway/sessions-patch.ts`:
- `null` → delete field, fall back to model default (clear override)
- `"off"` → persist explicit override
- Other values → normalize and persist

This ensures backward compatibility for API clients while fixing the `/think off`
issue in internal handlers.

Signed-off-by: Liu Yuan <namei.unix@gmail.com>
 		2026-02-09 16:08:15 -08:00
..
protocol fix(cron): share isolated announce flow + harden cron scheduling/delivery (#11641) 2026-02-07 19:46:01 -08:00
server fix: silence unused hook token url param (#9436) 2026-02-05 18:08:29 -08:00
server-methods Gateway: add CLAUDE.md symlink for AGENTS.md 2026-02-09 17:02:55 -06:00
assistant-identity.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
assistant-identity.ts feat(ui): add Agents dashboard 2026-02-02 21:31:17 -05:00
auth.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
auth.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
boot.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
boot.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
call.test.ts fix: context overflow compaction and subagent announce improvements (#11664) (thanks @tyler6204) 2026-02-07 20:02:32 -08:00
call.ts fix: context overflow compaction and subagent announce improvements (#11664) (thanks @tyler6204) 2026-02-07 20:02:32 -08:00
chat-abort.ts chore: Enable "curly" rule to avoid single-statement if confusion/errors. 2026-01-31 16:19:20 +09:00
chat-attachments.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
chat-attachments.ts chore: Enable "curly" rule to avoid single-statement if confusion/errors. 2026-01-31 16:19:20 +09:00
chat-sanitize.test.ts fix: hide message_id hints in web chat 2026-01-24 13:52:31 +00:00
chat-sanitize.ts chore: Enable "curly" rule to avoid single-statement if confusion/errors. 2026-01-31 16:19:20 +09:00
client.maxpayload.test.ts Gateway: enable canvas host + inject action bridge 2025-12-18 23:32:22 +01:00
client.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
client.ts chore: Enable `typescript/no-explicit-any` rule. 2026-02-02 16:18:09 +09:00
config-reload.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
config-reload.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
control-ui-shared.ts chore: Enable "curly" rule to avoid single-statement if confusion/errors. 2026-01-31 16:19:20 +09:00
control-ui.test.ts fix: harden control ui framing + ws origin 2026-02-03 16:00:57 -08:00
control-ui.ts fix: harden control ui framing + ws origin 2026-02-03 16:00:57 -08:00
device-auth.ts feat: enforce device-bound connect challenge 2026-01-20 13:04:19 +00:00
exec-approval-manager.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
gateway-cli-backend.live.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
gateway-models.profiles.live.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
gateway.e2e.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
hooks-mapping.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
hooks-mapping.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
hooks.test.ts fix: silence unused hook token url param (#9436) 2026-02-05 18:08:29 -08:00
hooks.ts fix: silence unused hook token url param (#9436) 2026-02-05 18:08:29 -08:00
http-common.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
http-utils.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
live-image-probe.ts refactor: consolidate PNG encoder and safeParseJson utilities (#12457) 2026-02-09 00:21:54 -08:00
net.test.ts fix(gateway): use LAN IP for WebSocket/probe URLs when bind=lan (#11448) 2026-02-07 19:16:51 -06:00
net.ts fix(gateway): use LAN IP for WebSocket/probe URLs when bind=lan (#11448) 2026-02-07 19:16:51 -06:00
node-command-policy.test.ts Gateway/Plugins: device pairing + phone control plugins (#11755) 2026-02-08 18:07:13 +01:00
node-command-policy.ts Gateway/Plugins: device pairing + phone control plugins (#11755) 2026-02-08 18:07:13 +01:00
node-registry.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
open-responses.schema.ts feat(gateway): implement OpenResponses /v1/responses endpoint phase 2 2026-01-20 07:37:01 +00:00
openai-http.e2e.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
openai-http.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
openresponses-http.e2e.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
openresponses-http.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
openresponses-parity.e2e.test.ts test(gateway): add OpenResponses parity E2E tests 2026-01-20 07:37:01 +00:00
origin-check.test.ts fix: harden control ui framing + ws origin 2026-02-03 16:00:57 -08:00
origin-check.ts fix: harden control ui framing + ws origin 2026-02-03 16:00:57 -08:00
probe.ts refactor: consolidate duplicate utility functions (#12439) 2026-02-08 23:59:43 -08:00
server-broadcast.test.ts TUI/Gateway: fix pi streaming + tool routing + model display + msg updating (#8432) 2026-02-04 17:12:16 -05:00
server-broadcast.ts TUI/Gateway: fix pi streaming + tool routing + model display + msg updating (#8432) 2026-02-04 17:12:16 -05:00
server-browser.ts chore: Enable "curly" rule to avoid single-statement if confusion/errors. 2026-01-31 16:19:20 +09:00
server-channels.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server-chat-registry.test.ts test(gateway): cover helper registries 2026-01-03 19:37:09 +01:00
server-chat.agent-events.test.ts TUI/Gateway: fix pi streaming + tool routing + model display + msg updating (#8432) 2026-02-04 17:12:16 -05:00
server-chat.ts TUI/Gateway: fix pi streaming + tool routing + model display + msg updating (#8432) 2026-02-04 17:12:16 -05:00
server-close.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server-constants.ts chore: Enable "curly" rule to avoid single-statement if confusion/errors. 2026-01-31 16:19:20 +09:00
server-cron.ts fix: cron scheduler reliability, store hardening, and UX improvements (#10776) 2026-02-06 18:03:03 -08:00
server-discovery-runtime.ts refactor: rename to openclaw 2026-01-30 03:16:21 +01:00
server-discovery.test.ts refactor: rename to openclaw 2026-01-30 03:16:21 +01:00
server-discovery.ts chore: Enable "curly" rule to avoid single-statement if confusion/errors. 2026-01-31 16:19:20 +09:00
server-http.ts fix: silence unused hook token url param (#9436) 2026-02-05 18:08:29 -08:00
server-lanes.ts refactor: use command lane enum 2026-01-20 10:51:25 +00:00
server-maintenance.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server-methods-list.ts feat(gateway): add agents.create/update/delete methods (#11045) 2026-02-07 16:47:58 -08:00
server-methods.ts feat(gateway): add agents.create/update/delete methods (#11045) 2026-02-07 16:47:58 -08:00
server-mobile-nodes.ts chore: Enable "curly" rule to avoid single-statement if confusion/errors. 2026-01-31 16:19:20 +09:00
server-model-catalog.ts refactor(gateway): split server runtime 2026-01-14 09:11:21 +00:00
server-node-events-types.ts refactor: remove bridge protocol 2026-01-19 10:08:29 +00:00
server-node-events.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server-node-events.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server-node-subscriptions.test.ts chore: Enable more lint rules, disable some that trigger a lot. Will clean up later. 2026-01-31 16:04:04 +09:00
server-node-subscriptions.ts chore: Enable "curly" rule to avoid single-statement if confusion/errors. 2026-01-31 16:19:20 +09:00
server-plugins.test.ts refactor: rename to openclaw 2026-01-30 03:16:21 +01:00
server-plugins.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server-reload-handlers.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server-restart-sentinel.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server-runtime-config.ts fix(ui): fix web UI after tsdown migration and typing changes 2026-02-03 13:56:20 -05:00
server-runtime-state.ts fix(gateway): require auth for canvas host and a2ui assets (#9518) (thanks @coygeek) 2026-02-05 16:37:58 -08:00
server-session-key.ts chore: Enable "curly" rule to avoid single-statement if confusion/errors. 2026-01-31 16:19:20 +09:00
server-shared.ts refactor(gateway): split server helpers 2026-01-03 19:37:09 +01:00
server-startup-log.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server-startup.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server-tailscale.ts chore: migrate to oxlint and oxfmt 2026-01-14 15:02:19 +00:00
server-utils.test.ts chore: migrate to oxlint and oxfmt 2026-01-14 15:02:19 +00:00
server-utils.ts chore: Enable "curly" rule to avoid single-statement if confusion/errors. 2026-01-31 16:19:20 +09:00
server-wizard-sessions.ts chore: Enable "curly" rule to avoid single-statement if confusion/errors. 2026-01-31 16:19:20 +09:00
server-ws-runtime.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server.agent.gateway-server-agent-a.e2e.test.ts chore: Enable "curly" rule to avoid single-statement if confusion/errors. 2026-01-31 16:19:20 +09:00
server.agent.gateway-server-agent-b.e2e.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server.auth.e2e.test.ts fix(gateway): require shared auth before device bypass 2026-02-02 16:56:38 -08:00
server.canvas-auth.e2e.test.ts fix(gateway): require auth for canvas host and a2ui assets (#9518) (thanks @coygeek) 2026-02-05 16:37:58 -08:00
server.channels.e2e.test.ts feat: Add Line plugin (#1630) 2026-01-25 12:22:36 +00:00
server.chat.gateway-server-chat-b.e2e.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server.chat.gateway-server-chat.e2e.test.ts TUI/Gateway: fix pi streaming + tool routing + model display + msg updating (#8432) 2026-02-04 17:12:16 -05:00
server.config-apply.e2e.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server.config-patch.e2e.test.ts security: redact credentials from config.get gateway responses (#9858) 2026-02-05 16:34:48 -08:00
server.cron.e2e.test.ts fix: cron scheduler reliability, store hardening, and UX improvements (#10776) 2026-02-06 18:03:03 -08:00
server.health.e2e.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server.hooks.e2e.test.ts fix: silence unused hook token url param (#9436) 2026-02-05 18:08:29 -08:00
server.impl.ts TUI/Gateway: fix pi streaming + tool routing + model display + msg updating (#8432) 2026-02-04 17:12:16 -05:00
server.ios-client-id.e2e.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server.models-voicewake-misc.e2e.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server.nodes.late-invoke.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server.reload.e2e.test.ts chore: Enable more lint rules, disable some that trigger a lot. Will clean up later. 2026-01-31 16:04:04 +09:00
server.roles-allowlist-update.e2e.test.ts fix(update): honor update.channel for update.run 2026-02-03 17:57:55 -08:00
server.sessions-send.e2e.test.ts chore: Enable "curly" rule to avoid single-statement if confusion/errors. 2026-01-31 16:19:20 +09:00
server.sessions.gateway-server-sessions-a.e2e.test.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
server.ts chore: migrate to oxlint and oxfmt 2026-01-14 15:02:19 +00:00
session-utils.fs.test.ts fix(paths): structurally resolve home dir to prevent Windows path bugs (#12125) 2026-02-08 20:06:29 -05:00
session-utils.fs.ts fix(paths): respect OPENCLAW_HOME for all internal path resolution (#12091) 2026-02-08 16:20:13 -05:00
session-utils.test.ts fix: cron scheduler reliability, store hardening, and UX improvements (#10776) 2026-02-06 18:03:03 -08:00
session-utils.ts fix: cron scheduler reliability, store hardening, and UX improvements (#10776) 2026-02-06 18:03:03 -08:00
session-utils.types.ts refactor: unify peer kind to ChatType, rename dm to direct (#11881) 2026-02-09 09:20:52 +09:00
sessions-patch.test.ts chore: Enable "curly" rule to avoid single-statement if confusion/errors. 2026-01-31 16:19:20 +09:00
sessions-patch.ts Fix: Honor `/think off` for reasoning-capable models 2026-02-09 16:08:15 -08:00
sessions-resolve.ts refactor: rename to openclaw 2026-01-30 03:16:21 +01:00
test-helpers.e2e.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
test-helpers.mocks.ts security: redact credentials from config.get gateway responses (#9858) 2026-02-05 16:34:48 -08:00
test-helpers.openai-mock.ts chore: Enable "curly" rule to avoid single-statement if confusion/errors. 2026-01-31 16:19:20 +09:00
test-helpers.server.ts security: redact credentials from config.get gateway responses (#9858) 2026-02-05 16:34:48 -08:00
test-helpers.ts refactor(src): split oversized modules 2026-01-14 01:17:56 +00:00
tools-invoke-http.test.ts chore: Enable `typescript/no-explicit-any` rule. 2026-02-02 16:18:09 +09:00
tools-invoke-http.ts chore: Enable `typescript/no-explicit-any` rule. 2026-02-02 16:18:09 +09:00
ws-log.test.ts fix: add agent context to ws logs 2026-01-17 20:37:36 +00:00
ws-log.ts chore: Enable "experimentalSortImports" in Oxfmt and reformat all imorts. 2026-02-01 10:03:47 +09:00
ws-logging.ts Gateway: optimize ws logs in normal mode 2025-12-18 13:27:52 +00:00