import fs from "node:fs"; import os from "node:os"; import path from "node:path"; import { describe, expect, it } from "vitest"; import { resolveNpmRunner, stageBundledPluginRuntimeDeps, } from "../../scripts/stage-bundled-plugin-runtime-deps.mjs"; describe("resolveNpmRunner", () => { it("anchors npm staging to the active node toolchain when npm-cli.js exists", () => { const execPath = "/Users/test/.nodenv/versions/24.13.0/bin/node"; const expectedNpmCliPath = path.posix.resolve( path.posix.dirname(execPath), "../lib/node_modules/npm/bin/npm-cli.js", ); const runner = resolveNpmRunner({ execPath, env: {}, existsSync: (candidate: string) => candidate === expectedNpmCliPath, platform: "darwin", }); expect(runner).toEqual({ command: execPath, args: [expectedNpmCliPath], shell: false, }); }); it("anchors Windows npm staging to the adjacent npm-cli.js without a shell", () => { const execPath = "C:\\nodejs\\node.exe"; const expectedNpmCliPath = path.win32.resolve( path.win32.dirname(execPath), "node_modules/npm/bin/npm-cli.js", ); const runner = resolveNpmRunner({ execPath, env: {}, existsSync: (candidate: string) => candidate === expectedNpmCliPath, platform: "win32", }); expect(runner).toEqual({ command: execPath, args: [expectedNpmCliPath], shell: false, }); }); it("uses an adjacent npm.exe on Windows without a shell", () => { const execPath = "C:\\nodejs\\node.exe"; const expectedNpmExePath = path.win32.resolve(path.win32.dirname(execPath), "npm.exe"); const runner = resolveNpmRunner({ execPath, env: {}, existsSync: (candidate: string) => candidate === expectedNpmExePath, npmArgs: ["install", "--silent"], platform: "win32", }); expect(runner).toEqual({ command: expectedNpmExePath, args: ["install", "--silent"], shell: false, }); }); it("wraps an adjacent npm.cmd via cmd.exe without enabling shell mode", () => { const execPath = "C:\\nodejs\\node.exe"; const npmCmdPath = path.win32.resolve(path.win32.dirname(execPath), "npm.cmd"); const runner = resolveNpmRunner({ comSpec: "C:\\Windows\\System32\\cmd.exe", execPath, env: {}, existsSync: (candidate: string) => candidate === npmCmdPath, npmArgs: ["install", "--omit=dev"], platform: "win32", }); expect(runner).toEqual({ command: "C:\\Windows\\System32\\cmd.exe", args: ["/d", "/s", "/c", `${npmCmdPath} install --omit=dev`], shell: false, windowsVerbatimArguments: true, }); }); it("prefixes PATH with the active node dir when falling back to bare npm", () => { expect( resolveNpmRunner({ execPath: "/tmp/node", env: { PATH: "/usr/bin:/bin", }, existsSync: () => false, platform: "linux", }), ).toEqual({ command: "npm", args: [], shell: false, env: { PATH: `/tmp${path.delimiter}/usr/bin:/bin`, }, }); }); it("fails closed on Windows when no toolchain-local npm CLI exists", () => { expect(() => resolveNpmRunner({ execPath: "C:\\node\\node.exe", env: { Path: "C:\\Windows\\System32", }, existsSync: () => false, platform: "win32", }), ).toThrow("OpenClaw refuses to shell out to bare npm on Windows"); }); }); describe("stageBundledPluginRuntimeDeps", () => { function createBundledPluginFixture(params: { packageJson: Record; pluginId?: string; }) { const repoRoot = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-runtime-deps-")); const pluginId = params.pluginId ?? "fixture-plugin"; const pluginDir = path.join(repoRoot, "dist", "extensions", pluginId); fs.mkdirSync(pluginDir, { recursive: true }); fs.writeFileSync( path.join(pluginDir, "package.json"), `${JSON.stringify(params.packageJson, null, 2)}\n`, "utf8", ); return { pluginDir, repoRoot }; } it("skips restaging when runtime deps stamp matches the sanitized manifest", () => { const { pluginDir, repoRoot } = createBundledPluginFixture({ packageJson: { name: "@openclaw/fixture-plugin", version: "1.0.0", dependencies: { "left-pad": "1.3.0" }, peerDependencies: { openclaw: "^1.0.0" }, peerDependenciesMeta: { openclaw: { optional: true } }, devDependencies: { openclaw: "^1.0.0" }, openclaw: { bundle: { stageRuntimeDependencies: true } }, }, }); const nodeModulesDir = path.join(pluginDir, "node_modules"); fs.mkdirSync(nodeModulesDir, { recursive: true }); fs.writeFileSync(path.join(nodeModulesDir, "marker.txt"), "present\n", "utf8"); let installCount = 0; stageBundledPluginRuntimeDeps({ cwd: repoRoot, installPluginRuntimeDepsImpl: ({ fingerprint }: { fingerprint: string }) => { installCount += 1; fs.writeFileSync( path.join(pluginDir, ".openclaw-runtime-deps-stamp.json"), `${JSON.stringify({ fingerprint }, null, 2)}\n`, "utf8", ); }, }); stageBundledPluginRuntimeDeps({ cwd: repoRoot, installPluginRuntimeDepsImpl: () => { installCount += 1; }, }); expect(installCount).toBe(1); expect(fs.existsSync(path.join(nodeModulesDir, "marker.txt"))).toBe(true); expect(JSON.parse(fs.readFileSync(path.join(pluginDir, "package.json"), "utf8"))).toEqual({ name: "@openclaw/fixture-plugin", version: "1.0.0", dependencies: { "left-pad": "1.3.0" }, openclaw: { bundle: { stageRuntimeDependencies: true } }, }); }); it("restages when the manifest-owned runtime deps change", () => { const { pluginDir, repoRoot } = createBundledPluginFixture({ packageJson: { name: "@openclaw/fixture-plugin", version: "1.0.0", dependencies: { "left-pad": "1.3.0" }, openclaw: { bundle: { stageRuntimeDependencies: true } }, }, }); let installCount = 0; const stageOnce = () => stageBundledPluginRuntimeDeps({ cwd: repoRoot, installPluginRuntimeDepsImpl: ({ fingerprint }: { fingerprint: string }) => { installCount += 1; const nodeModulesDir = path.join(pluginDir, "node_modules"); fs.mkdirSync(nodeModulesDir, { recursive: true }); fs.writeFileSync(path.join(nodeModulesDir, "marker.txt"), `${installCount}\n`, "utf8"); fs.writeFileSync( path.join(pluginDir, ".openclaw-runtime-deps-stamp.json"), `${JSON.stringify({ fingerprint }, null, 2)}\n`, "utf8", ); }, }); stageOnce(); const updatedPackageJson = JSON.parse( fs.readFileSync(path.join(pluginDir, "package.json"), "utf8"), ); updatedPackageJson.dependencies["is-odd"] = "3.0.1"; fs.writeFileSync( path.join(pluginDir, "package.json"), `${JSON.stringify(updatedPackageJson, null, 2)}\n`, "utf8", ); stageOnce(); expect(installCount).toBe(2); expect(fs.readFileSync(path.join(pluginDir, "node_modules", "marker.txt"), "utf8")).toBe("2\n"); }); });