From f59c52bc169ba37ecc28a3c7fd1bdac04f93162b Mon Sep 17 00:00:00 2001 From: Tak Hoffman <781889+Takhoffman@users.noreply.github.com> Date: Fri, 3 Apr 2026 15:20:58 -0500 Subject: [PATCH] fix: honor slack default setup status --- extensions/slack/src/setup-core.ts | 5 +--- extensions/slack/src/setup-surface.test.ts | 28 ++++++++++++++++++++++ 2 files changed, 29 insertions(+), 4 deletions(-) diff --git a/extensions/slack/src/setup-core.ts b/extensions/slack/src/setup-core.ts index b49043fb338..74a6ff93ff1 100644 --- a/extensions/slack/src/setup-core.ts +++ b/extensions/slack/src/setup-core.ts @@ -167,10 +167,7 @@ export function createSlackSetupWizardBase(handlers: { configuredScore: 2, unconfiguredScore: 1, resolveConfigured: ({ cfg, accountId }) => - (accountId ? [accountId] : listSlackAccountIds(cfg)).some((resolvedAccountId) => { - const account = inspectSlackAccount({ cfg, accountId: resolvedAccountId }); - return account.configured; - }), + inspectSlackAccount({ cfg, accountId }).configured, }), introNote: { title: "Slack socket mode tokens", diff --git a/extensions/slack/src/setup-surface.test.ts b/extensions/slack/src/setup-surface.test.ts index 8a279b8eef2..228d44ce895 100644 --- a/extensions/slack/src/setup-surface.test.ts +++ b/extensions/slack/src/setup-surface.test.ts @@ -118,3 +118,31 @@ describe("slackSetupWizard.dmPolicy", () => { expect(next?.channels?.slack?.accounts?.alerts?.allowFrom).toEqual(["U123", "*"]); }); }); + +describe("slackSetupWizard.status", () => { + it("uses configured defaultAccount for omitted setup configured state", async () => { + const configured = await slackSetupWizard.status.resolveConfigured({ + cfg: { + channels: { + slack: { + defaultAccount: "work", + botToken: "xoxb-root", + appToken: "xapp-root", + accounts: { + alerts: { + botToken: "xoxb-alerts", + appToken: "xapp-alerts", + }, + work: { + botToken: "", + appToken: "", + }, + }, + }, + }, + } as OpenClawConfig, + }); + + expect(configured).toBe(false); + }); +});