From f0179d3b4af77c5fcad096dcdce4c4f31214f30f Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Sat, 14 Mar 2026 02:26:01 +0000
Subject: [PATCH] test: share workspace skills snapshot helpers

---
 ...skills.buildworkspaceskillsnapshot.test.ts | 127 +++++++++---------
 1 file changed, 67 insertions(+), 60 deletions(-)

diff --git a/src/agents/skills.buildworkspaceskillsnapshot.test.ts b/src/agents/skills.buildworkspaceskillsnapshot.test.ts
index aec0da8b49a..1292841ed13 100644
--- a/src/agents/skills.buildworkspaceskillsnapshot.test.ts
+++ b/src/agents/skills.buildworkspaceskillsnapshot.test.ts
@@ -43,22 +43,44 @@ function withWorkspaceHome<T>(workspaceDir: string, cb: () => T): T {
   return withEnv({ HOME: workspaceDir, PATH: "" }, cb);
 }
 
+function buildSnapshot(
+  workspaceDir: string,
+  options?: Parameters<typeof buildWorkspaceSkillSnapshot>[1],
+) {
+  return withWorkspaceHome(workspaceDir, () =>
+    buildWorkspaceSkillSnapshot(workspaceDir, {
+      managedSkillsDir: path.join(workspaceDir, ".managed"),
+      bundledSkillsDir: path.join(workspaceDir, ".bundled"),
+      ...options,
+    }),
+  );
+}
+
 async function cloneTemplateDir(templateDir: string, prefix: string): Promise<string> {
   const cloned = await fixtureSuite.createCaseDir(prefix);
   await fs.cp(templateDir, cloned, { recursive: true });
   return cloned;
 }
 
+function expectSnapshotNamesAndPrompt(
+  snapshot: ReturnType<typeof buildWorkspaceSkillSnapshot>,
+  params: { contains?: string[]; omits?: string[] },
+) {
+  for (const name of params.contains ?? []) {
+    expect(snapshot.skills.map((skill) => skill.name)).toContain(name);
+    expect(snapshot.prompt).toContain(name);
+  }
+  for (const name of params.omits ?? []) {
+    expect(snapshot.skills.map((skill) => skill.name)).not.toContain(name);
+    expect(snapshot.prompt).not.toContain(name);
+  }
+}
+
 describe("buildWorkspaceSkillSnapshot", () => {
   it("returns an empty snapshot when skills dirs are missing", async () => {
     const workspaceDir = await fixtureSuite.createCaseDir("workspace");
 
-    const snapshot = withWorkspaceHome(workspaceDir, () =>
-      buildWorkspaceSkillSnapshot(workspaceDir, {
-        managedSkillsDir: path.join(workspaceDir, ".managed"),
-        bundledSkillsDir: path.join(workspaceDir, ".bundled"),
-      }),
-    );
+    const snapshot = buildSnapshot(workspaceDir);
 
     expect(snapshot.prompt).toBe("");
     expect(snapshot.skills).toEqual([]);
@@ -78,12 +100,7 @@ describe("buildWorkspaceSkillSnapshot", () => {
       frontmatterExtra: "disable-model-invocation: true",
     });
 
-    const snapshot = withWorkspaceHome(workspaceDir, () =>
-      buildWorkspaceSkillSnapshot(workspaceDir, {
-        managedSkillsDir: path.join(workspaceDir, ".managed"),
-        bundledSkillsDir: path.join(workspaceDir, ".bundled"),
-      }),
-    );
+    const snapshot = buildSnapshot(workspaceDir);
 
     expect(snapshot.prompt).toContain("visible-skill");
     expect(snapshot.prompt).not.toContain("hidden-skill");
@@ -204,24 +221,20 @@ describe("buildWorkspaceSkillSnapshot", () => {
       body: "x".repeat(5_000),
     });
 
-    const snapshot = withWorkspaceHome(workspaceDir, () =>
-      buildWorkspaceSkillSnapshot(workspaceDir, {
-        config: {
-          skills: {
-            limits: {
-              maxSkillFileBytes: 1000,
-            },
+    const snapshot = buildSnapshot(workspaceDir, {
+      config: {
+        skills: {
+          limits: {
+            maxSkillFileBytes: 1000,
           },
         },
-        managedSkillsDir: path.join(workspaceDir, ".managed"),
-        bundledSkillsDir: path.join(workspaceDir, ".bundled"),
-      }),
-    );
+      },
+    });
 
-    expect(snapshot.skills.map((s) => s.name)).toContain("small-skill");
-    expect(snapshot.skills.map((s) => s.name)).not.toContain("big-skill");
-    expect(snapshot.prompt).toContain("small-skill");
-    expect(snapshot.prompt).not.toContain("big-skill");
+    expectSnapshotNamesAndPrompt(snapshot, {
+      contains: ["small-skill"],
+      omits: ["big-skill"],
+    });
   });
 
   it("detects nested skills roots beyond the first 25 entries", async () => {
@@ -241,26 +254,23 @@ describe("buildWorkspaceSkillSnapshot", () => {
       description: "Nested skill discovered late",
     });
 
-    const snapshot = withWorkspaceHome(workspaceDir, () =>
-      buildWorkspaceSkillSnapshot(workspaceDir, {
-        config: {
-          skills: {
-            load: {
-              extraDirs: [repoDir],
-            },
-            limits: {
-              maxCandidatesPerRoot: 30,
-              maxSkillsLoadedPerSource: 30,
-            },
+    const snapshot = buildSnapshot(workspaceDir, {
+      config: {
+        skills: {
+          load: {
+            extraDirs: [repoDir],
+          },
+          limits: {
+            maxCandidatesPerRoot: 30,
+            maxSkillsLoadedPerSource: 30,
           },
         },
-        managedSkillsDir: path.join(workspaceDir, ".managed"),
-        bundledSkillsDir: path.join(workspaceDir, ".bundled"),
-      }),
-    );
+      },
+    });
 
-    expect(snapshot.skills.map((s) => s.name)).toContain("late-skill");
-    expect(snapshot.prompt).toContain("late-skill");
+    expectSnapshotNamesAndPrompt(snapshot, {
+      contains: ["late-skill"],
+    });
   });
 
   it("enforces maxSkillFileBytes for root-level SKILL.md", async () => {
@@ -274,24 +284,21 @@ describe("buildWorkspaceSkillSnapshot", () => {
       body: "x".repeat(5_000),
     });
 
-    const snapshot = withWorkspaceHome(workspaceDir, () =>
-      buildWorkspaceSkillSnapshot(workspaceDir, {
-        config: {
-          skills: {
-            load: {
-              extraDirs: [rootSkillDir],
-            },
-            limits: {
-              maxSkillFileBytes: 1000,
-            },
+    const snapshot = buildSnapshot(workspaceDir, {
+      config: {
+        skills: {
+          load: {
+            extraDirs: [rootSkillDir],
+          },
+          limits: {
+            maxSkillFileBytes: 1000,
           },
         },
-        managedSkillsDir: path.join(workspaceDir, ".managed"),
-        bundledSkillsDir: path.join(workspaceDir, ".bundled"),
-      }),
-    );
+      },
+    });
 
-    expect(snapshot.skills.map((s) => s.name)).not.toContain("root-big-skill");
-    expect(snapshot.prompt).not.toContain("root-big-skill");
+    expectSnapshotNamesAndPrompt(snapshot, {
+      omits: ["root-big-skill"],
+    });
   });
 });