From d7f9035e8043584b16133bafaf6859ab7df954e9 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 13 Mar 2026 21:26:12 +0000
Subject: [PATCH] test: share sandbox default assertions

---
 .../run.sandbox-config-preserved.test.ts      | 59 +++++++++----------
 1 file changed, 27 insertions(+), 32 deletions(-)

diff --git a/src/cron/isolated-agent/run.sandbox-config-preserved.test.ts b/src/cron/isolated-agent/run.sandbox-config-preserved.test.ts
index 28f3d87cb09..edaee62daa6 100644
--- a/src/cron/isolated-agent/run.sandbox-config-preserved.test.ts
+++ b/src/cron/isolated-agent/run.sandbox-config-preserved.test.ts
@@ -54,6 +54,31 @@ function makeParams(overrides?: Record<string, unknown>) {
   };
 }
 
+function expectDefaultSandboxPreserved(
+  runCfg:
+    | {
+        agents?: { defaults?: { sandbox?: unknown } };
+      }
+    | undefined,
+) {
+  expect(runCfg?.agents?.defaults?.sandbox).toEqual({
+    mode: "all",
+    workspaceAccess: "rw",
+    docker: {
+      network: "none",
+      dangerouslyAllowContainerNamespaceJoin: true,
+      dangerouslyAllowExternalBindSources: true,
+    },
+    browser: {
+      enabled: true,
+      autoStart: false,
+    },
+    prune: {
+      maxAgeDays: 7,
+    },
+  });
+}
+
 describe("runCronIsolatedAgentTurn sandbox config preserved", () => {
   let previousFastTestEnv: string | undefined;
 
@@ -79,22 +104,7 @@ describe("runCronIsolatedAgentTurn sandbox config preserved", () => {
 
     expect(runWithModelFallbackMock).toHaveBeenCalledTimes(1);
     const runCfg = runWithModelFallbackMock.mock.calls[0]?.[0]?.cfg;
-    expect(runCfg?.agents?.defaults?.sandbox).toEqual({
-      mode: "all",
-      workspaceAccess: "rw",
-      docker: {
-        network: "none",
-        dangerouslyAllowContainerNamespaceJoin: true,
-        dangerouslyAllowExternalBindSources: true,
-      },
-      browser: {
-        enabled: true,
-        autoStart: false,
-      },
-      prune: {
-        maxAgeDays: 7,
-      },
-    });
+    expectDefaultSandboxPreserved(runCfg);
   });
 
   it("keeps global sandbox defaults when agent override is partial", async () => {
@@ -118,22 +128,7 @@ describe("runCronIsolatedAgentTurn sandbox config preserved", () => {
     const runCfg = runWithModelFallbackMock.mock.calls[0]?.[0]?.cfg;
     const resolvedSandbox = resolveSandboxConfigForAgent(runCfg, "specialist");
 
-    expect(runCfg?.agents?.defaults?.sandbox).toEqual({
-      mode: "all",
-      workspaceAccess: "rw",
-      docker: {
-        network: "none",
-        dangerouslyAllowContainerNamespaceJoin: true,
-        dangerouslyAllowExternalBindSources: true,
-      },
-      browser: {
-        enabled: true,
-        autoStart: false,
-      },
-      prune: {
-        maxAgeDays: 7,
-      },
-    });
+    expectDefaultSandboxPreserved(runCfg);
     expect(resolvedSandbox.mode).toBe("all");
     expect(resolvedSandbox.workspaceAccess).toBe("rw");
     expect(resolvedSandbox.docker).toMatchObject({