nyrn
/
openclaw
mirror of https://github.com/openclaw/openclaw.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor(command-tests): share workspace harness

This commit is contained in:
Peter Steinberger 2026-03-17 06:53:34 +00:00
parent 276803095d
commit d08d43fb1a
3 changed files with 32 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/auto-reply/reply/commands-filesystem.test-support.ts Normal file
View File

@ -0,0 +1,20 @@
import fs from "node:fs/promises";
import os from "node:os";
import path from "node:path";
export function createCommandWorkspaceHarness(prefix: string) {
const tempDirs: string[] = [];
return {
async createWorkspace(): Promise<string> {
const dir = await fs.mkdtemp(path.join(os.tmpdir(), prefix));
tempDirs.push(dir);
return dir;
},
async cleanupWorkspaces() {
await Promise.all(
tempDirs.splice(0).map((dir) => fs.rm(dir, { recursive: true, force: true })),
);
},
};
}

22
src/auto-reply/reply/commands-mcp.test.ts
View File

@ -1,19 +1,11 @@
import fs from "node:fs/promises";
import os from "node:os";
import path from "node:path";
import { afterEach, describe, expect, it } from "vitest";
import type { OpenClawConfig } from "../../config/config.js";
import { withTempHome } from "../../config/home-env.test-harness.js";
import { handleCommands } from "./commands-core.js";
import { createCommandWorkspaceHarness } from "./commands-filesystem.test-support.js";
import { buildCommandTestParams } from "./commands.test-harness.js";
const tempDirs: string[] = [];
async function createWorkspace(): Promise<string> {
const dir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-command-mcp-"));
tempDirs.push(dir);
return dir;
}
const workspaceHarness = createCommandWorkspaceHarness("openclaw-command-mcp-");
function buildCfg(): OpenClawConfig {
return {
@ -26,14 +18,12 @@ function buildCfg(): OpenClawConfig {
describe("handleCommands /mcp", () => {
afterEach(async () => {
await Promise.all(
tempDirs.splice(0).map((dir) => fs.rm(dir, { recursive: true, force: true })),
);
await workspaceHarness.cleanupWorkspaces();
});
it("writes MCP config and shows it back", async () => {
await withTempHome("openclaw-command-mcp-home-", async () => {
const workspaceDir = await createWorkspace();
const workspaceDir = await workspaceHarness.createWorkspace();
const setParams = buildCommandTestParams(
'/mcp set context7={"command":"uvx","args":["context7-mcp"]}',
buildCfg(),
@ -57,7 +47,7 @@ describe("handleCommands /mcp", () => {
it("rejects internal writes without operator.admin", async () => {
await withTempHome("openclaw-command-mcp-home-", async () => {
const workspaceDir = await createWorkspace();
const workspaceDir = await workspaceHarness.createWorkspace();
const params = buildCommandTestParams(
'/mcp set context7={"command":"uvx","args":["context7-mcp"]}',
buildCfg(),
@ -77,7 +67,7 @@ describe("handleCommands /mcp", () => {
it("accepts non-stdio MCP config at the config layer", async () => {
await withTempHome("openclaw-command-mcp-home-", async () => {
const workspaceDir = await createWorkspace();
const workspaceDir = await workspaceHarness.createWorkspace();
const params = buildCommandTestParams(
'/mcp set remote={"url":"https://example.com/mcp"}',
buildCfg(),

20
src/auto-reply/reply/commands-plugins.test.ts
View File

@ -1,19 +1,13 @@
import fs from "node:fs/promises";
import os from "node:os";
import path from "node:path";
import { afterEach, describe, expect, it } from "vitest";
import type { OpenClawConfig } from "../../config/config.js";
import { withTempHome } from "../../config/home-env.test-harness.js";
import { handleCommands } from "./commands-core.js";
import { createCommandWorkspaceHarness } from "./commands-filesystem.test-support.js";
import { buildCommandTestParams } from "./commands.test-harness.js";
const tempDirs: string[] = [];
async function createWorkspace(): Promise<string> {
const dir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-command-plugins-"));
tempDirs.push(dir);
return dir;
}
const workspaceHarness = createCommandWorkspaceHarness("openclaw-command-plugins-");
async function createClaudeBundlePlugin(params: { workspaceDir: string; pluginId: string }) {
const pluginDir = path.join(params.workspaceDir, ".openclaw", "extensions", params.pluginId);
@ -38,14 +32,12 @@ function buildCfg(): OpenClawConfig {
describe("handleCommands /plugins", () => {
afterEach(async () => {
await Promise.all(
tempDirs.splice(0).map((dir) => fs.rm(dir, { recursive: true, force: true })),
);
await workspaceHarness.cleanupWorkspaces();
});
it("lists discovered plugins and shows plugin details", async () => {
await withTempHome("openclaw-command-plugins-home-", async () => {
const workspaceDir = await createWorkspace();
const workspaceDir = await workspaceHarness.createWorkspace();
await createClaudeBundlePlugin({ workspaceDir, pluginId: "superpowers" });
const listParams = buildCommandTestParams("/plugins list", buildCfg(), undefined, {
@ -69,7 +61,7 @@ describe("handleCommands /plugins", () => {
it("enables and disables a discovered plugin", async () => {
await withTempHome("openclaw-command-plugins-home-", async () => {
const workspaceDir = await createWorkspace();
const workspaceDir = await workspaceHarness.createWorkspace();
await createClaudeBundlePlugin({ workspaceDir, pluginId: "superpowers" });
const enableParams = buildCommandTestParams(
@ -113,7 +105,7 @@ describe("handleCommands /plugins", () => {
it("rejects internal writes without operator.admin", async () => {
await withTempHome("openclaw-command-plugins-home-", async () => {
const workspaceDir = await createWorkspace();
const workspaceDir = await workspaceHarness.createWorkspace();
await createClaudeBundlePlugin({ workspaceDir, pluginId: "superpowers" });
const params = buildCommandTestParams(