From ad52724d9ac11eadc1a734e45aae0793e870116b Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 13 Mar 2026 19:07:08 +0000
Subject: [PATCH] refactor: share fallback skip assertions

---
 src/agents/model-fallback.probe.test.ts | 26 +++++++++++++++----------
 1 file changed, 16 insertions(+), 10 deletions(-)

diff --git a/src/agents/model-fallback.probe.test.ts b/src/agents/model-fallback.probe.test.ts
index d08bd0d4beb..3969416cd38 100644
--- a/src/agents/model-fallback.probe.test.ts
+++ b/src/agents/model-fallback.probe.test.ts
@@ -46,6 +46,20 @@ function expectFallbackUsed(
   expect(result.attempts[0]?.reason).toBe("rate_limit");
 }
 
+function expectPrimarySkippedForReason(
+  result: { result: unknown; attempts: Array<{ reason?: string }> },
+  run: {
+    (...args: unknown[]): unknown;
+    mock: { calls: unknown[][] };
+  },
+  reason: string,
+) {
+  expect(result.result).toBe("ok");
+  expect(run).toHaveBeenCalledTimes(1);
+  expect(run).toHaveBeenCalledWith("anthropic", "claude-haiku-3-5");
+  expect(result.attempts[0]?.reason).toBe(reason);
+}
+
 function expectPrimaryProbeSuccess(
   result: { result: unknown },
   run: {
@@ -183,11 +197,7 @@ describe("runWithModelFallback – probe logic", () => {
     const run = vi.fn().mockResolvedValue("ok");
 
     const result = await runPrimaryCandidate(cfg, run);
-
-    expect(result.result).toBe("ok");
-    expect(run).toHaveBeenCalledTimes(1);
-    expect(run).toHaveBeenCalledWith("anthropic", "claude-haiku-3-5");
-    expect(result.attempts[0]?.reason).toBe("billing");
+    expectPrimarySkippedForReason(result, run, "billing");
   });
 
   it("probes primary model when within 2-min margin of cooldown expiry", async () => {
@@ -540,10 +550,6 @@ describe("runWithModelFallback – probe logic", () => {
     const run = vi.fn().mockResolvedValue("ok");
 
     const result = await runPrimaryCandidate(cfg, run);
-
-    expect(result.result).toBe("ok");
-    expect(run).toHaveBeenCalledTimes(1);
-    expect(run).toHaveBeenCalledWith("anthropic", "claude-haiku-3-5");
-    expect(result.attempts[0]?.reason).toBe("billing");
+    expectPrimarySkippedForReason(result, run, "billing");
   });
 });