From a3d2021eea8991cfcf1e8108be4db165ee260f72 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Mon, 2 Mar 2026 15:06:25 +0000
Subject: [PATCH] test(cron): stabilize model precedence mocks in bun runs
 (#31594)

---
 ...-agent.uses-last-non-empty-agent-text-as.test.ts | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/cron/isolated-agent.uses-last-non-empty-agent-text-as.test.ts b/src/cron/isolated-agent.uses-last-non-empty-agent-text-as.test.ts
index 7c375dfea2f..02e1e054fca 100644
--- a/src/cron/isolated-agent.uses-last-non-empty-agent-text-as.test.ts
+++ b/src/cron/isolated-agent.uses-last-non-empty-agent-text-as.test.ts
@@ -385,7 +385,7 @@ describe("runCronIsolatedAgentTurn", () => {
 
   it("applies model overrides with correct precedence", async () => {
     await withTempHome(async (home) => {
-      vi.mocked(loadModelCatalog).mockResolvedValue([
+      const deterministicCatalog = [
         {
           id: "gpt-4.1-mini",
           name: "GPT-4.1 Mini",
@@ -396,7 +396,8 @@ describe("runCronIsolatedAgentTurn", () => {
           name: "Claude Opus 4.5",
           provider: "anthropic",
         },
-      ]);
+      ];
+      vi.mocked(loadModelCatalog).mockResolvedValue(deterministicCatalog);
 
       let res = (
         await runCronTurn(home, {
@@ -410,7 +411,8 @@ describe("runCronIsolatedAgentTurn", () => {
       expect(res.status).toBe("ok");
       expectEmbeddedProviderModel({ provider: "openai", model: "gpt-4.1-mini" });
 
-      vi.clearAllMocks();
+      vi.mocked(runEmbeddedPiAgent).mockClear();
+      vi.mocked(loadModelCatalog).mockResolvedValue(deterministicCatalog);
       res = (
         await runTurnWithStoredModelOverride(home, {
           kind: "agentTurn",
@@ -421,7 +423,8 @@ describe("runCronIsolatedAgentTurn", () => {
       expect(res.status).toBe("ok");
       expectEmbeddedProviderModel({ provider: "openai", model: "gpt-4.1-mini" });
 
-      vi.clearAllMocks();
+      vi.mocked(runEmbeddedPiAgent).mockClear();
+      vi.mocked(loadModelCatalog).mockResolvedValue(deterministicCatalog);
       res = (
         await runTurnWithStoredModelOverride(home, {
           kind: "agentTurn",
@@ -444,7 +447,7 @@ describe("runCronIsolatedAgentTurn", () => {
         model: GMAIL_MODEL.replace("openrouter/", ""),
       });
 
-      vi.clearAllMocks();
+      vi.mocked(runEmbeddedPiAgent).mockClear();
       res = (
         await runGmailHookTurn(home, {
           "agent:main:hook:gmail:msg-1": {