nyrn
/
openclaw
mirror of https://github.com/openclaw/openclaw.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(memory-flush): ban timestamped variant files in default flush prompt 

Add an explicit instruction to DEFAULT_MEMORY_FLUSH_PROMPT prohibiting the
creation of timestamped variant files (e.g. YYYY-MM-DD-HHMM.md) alongside the
canonical daily log file (YYYY-MM-DD.md).

Before this change, the default prompt only instructed the agent to append to
existing files, which prevented overwrites (#6877 / PR #6878) but did not
prevent agents from creating new timestamped variants instead of appending to
the canonical file. This resulted in orphaned fragment files like
`2026-03-03-1709.md` accumulating in the memory/ directory across dates.

The updated prompt now contains two explicit guards:
  1. Append-only: do not overwrite existing entries (existing, from #6878)
  2. No variants: always use the canonical YYYY-MM-DD.md filename

Also adds two tests to memory-flush.test.ts that verify both instructions are
present in the default prompt, preventing future accidental removal.

Fixes #34919

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
zerone0x 2026-03-04 21:09:00 +01:00 committed by Josh Lehman
parent 8088218f46
commit a1ee62d7a1
No known key found for this signature in database
GPG Key ID: D141B425AC7F876B
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/auto-reply/reply/memory-flush.test.ts
View File

@ -1,6 +1,6 @@
import { describe, expect, it } from "vitest";
import type { OpenClawConfig } from "../../config/config.js";
import { resolveMemoryFlushPromptForRun } from "./memory-flush.js";
import { DEFAULT_MEMORY_FLUSH_PROMPT, resolveMemoryFlushPromptForRun } from "./memory-flush.js";
describe("resolveMemoryFlushPromptForRun", () => {
const cfg = {
@ -36,3 +36,16 @@ describe("resolveMemoryFlushPromptForRun", () => {
expect((prompt.match(/Current time:/g) ?? []).length).toBe(1);
});
});
describe("DEFAULT_MEMORY_FLUSH_PROMPT", () => {
it("includes append-only instruction to prevent overwrites (#6877)", () => {
expect(DEFAULT_MEMORY_FLUSH_PROMPT).toMatch(/APPEND/i);
expect(DEFAULT_MEMORY_FLUSH_PROMPT).toContain("do not overwrite");
});
it("includes anti-fragmentation instruction to prevent timestamped variant files (#34919)", () => {
// Agents must not create YYYY-MM-DD-HHMM.md variants alongside the canonical file
expect(DEFAULT_MEMORY_FLUSH_PROMPT).toContain("timestamped variant");
expect(DEFAULT_MEMORY_FLUSH_PROMPT).toContain("YYYY-MM-DD.md");
});
});

3
src/auto-reply/reply/memory-flush.ts
View File

@ -13,7 +13,8 @@ export const DEFAULT_MEMORY_FLUSH_FORCE_TRANSCRIPT_BYTES = 2 * 1024 * 1024;
export const DEFAULT_MEMORY_FLUSH_PROMPT = [
"Pre-compaction memory flush.",
"Store durable memories now (use memory/YYYY-MM-DD.md; create memory/ if needed).",
"IMPORTANT: If the file already exists, APPEND new content only and do not overwrite existing entries.",
"IMPORTANT: If the file already exists, APPEND new content only — do not overwrite existing entries.",
"Do NOT create timestamped variant files (e.g., YYYY-MM-DD-HHMM.md); always use the canonical YYYY-MM-DD.md filename.",
`If nothing to store, reply with ${SILENT_REPLY_TOKEN}.`,
].join(" ");