From 809785dcd79d712e1847d3e8e7879a587b9b8c4f Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 13 Mar 2026 22:28:23 +0000
Subject: [PATCH] test: dedupe discord provider account config harness

---
 src/discord/monitor/provider.test.ts | 92 +++++++++++++---------------
 1 file changed, 43 insertions(+), 49 deletions(-)

diff --git a/src/discord/monitor/provider.test.ts b/src/discord/monitor/provider.test.ts
index 91f61a7ce1f..8fdab085f53 100644
--- a/src/discord/monitor/provider.test.ts
+++ b/src/discord/monitor/provider.test.ts
@@ -16,6 +16,15 @@ type PluginCommandSpecMock = {
   acceptsArgs: boolean;
 };
 
+function baseDiscordAccountConfig() {
+  return {
+    commands: { native: true, nativeSkills: false },
+    voice: { enabled: false },
+    agentComponents: { enabled: false },
+    execApprovals: { enabled: false },
+  };
+}
+
 const {
   clientFetchUserMock,
   clientGetPluginMock,
@@ -91,12 +100,7 @@ const {
     resolveDiscordAccountMock: vi.fn(() => ({
       accountId: "default",
       token: "cfg-token",
-      config: {
-        commands: { native: true, nativeSkills: false },
-        voice: { enabled: false },
-        agentComponents: { enabled: false },
-        execApprovals: { enabled: false },
-      },
+      config: baseDiscordAccountConfig(),
     })),
     resolveDiscordAllowlistConfigMock: vi.fn(async () => ({
       guildEntries: undefined,
@@ -108,6 +112,23 @@ const {
   };
 });
 
+function mockResolvedDiscordAccountConfig(overrides: Record<string, unknown>) {
+  resolveDiscordAccountMock.mockImplementation(() => ({
+    accountId: "default",
+    token: "cfg-token",
+    config: {
+      ...baseDiscordAccountConfig(),
+      ...overrides,
+    },
+  }));
+}
+
+function getFirstDiscordMessageHandlerParams<T extends object>() {
+  expect(createDiscordMessageHandlerMock).toHaveBeenCalledTimes(1);
+  const firstCall = createDiscordMessageHandlerMock.mock.calls.at(0) as [T] | undefined;
+  return firstCall?.[0];
+}
+
 vi.mock("@buape/carbon", () => {
   class ReadyListener {}
   class Client {
@@ -663,17 +684,9 @@ describe("monitorDiscordProvider", () => {
   it("forwards custom eventQueue config from discord config to Carbon Client", async () => {
     const { monitorDiscordProvider } = await import("./provider.js");
 
-    resolveDiscordAccountMock.mockImplementation(() => ({
-      accountId: "default",
-      token: "cfg-token",
-      config: {
-        commands: { native: true, nativeSkills: false },
-        voice: { enabled: false },
-        agentComponents: { enabled: false },
-        execApprovals: { enabled: false },
-        eventQueue: { listenerTimeout: 300_000 },
-      },
-    }));
+    mockResolvedDiscordAccountConfig({
+      eventQueue: { listenerTimeout: 300_000 },
+    });
 
     await monitorDiscordProvider({
       config: baseConfig(),
@@ -687,28 +700,19 @@ describe("monitorDiscordProvider", () => {
   it("does not reuse eventQueue.listenerTimeout as the queued inbound worker timeout", async () => {
     const { monitorDiscordProvider } = await import("./provider.js");
 
-    resolveDiscordAccountMock.mockImplementation(() => ({
-      accountId: "default",
-      token: "cfg-token",
-      config: {
-        commands: { native: true, nativeSkills: false },
-        voice: { enabled: false },
-        agentComponents: { enabled: false },
-        execApprovals: { enabled: false },
-        eventQueue: { listenerTimeout: 50_000 },
-      },
-    }));
+    mockResolvedDiscordAccountConfig({
+      eventQueue: { listenerTimeout: 50_000 },
+    });
 
     await monitorDiscordProvider({
       config: baseConfig(),
       runtime: baseRuntime(),
     });
 
-    expect(createDiscordMessageHandlerMock).toHaveBeenCalledTimes(1);
-    const firstCall = createDiscordMessageHandlerMock.mock.calls.at(0) as
-      | [{ workerRunTimeoutMs?: number; listenerTimeoutMs?: number }]
-      | undefined;
-    const params = firstCall?.[0];
+    const params = getFirstDiscordMessageHandlerParams<{
+      workerRunTimeoutMs?: number;
+      listenerTimeoutMs?: number;
+    }>();
     expect(params?.workerRunTimeoutMs).toBeUndefined();
     expect("listenerTimeoutMs" in (params ?? {})).toBe(false);
   });
@@ -716,28 +720,18 @@ describe("monitorDiscordProvider", () => {
   it("forwards inbound worker timeout config to the Discord message handler", async () => {
     const { monitorDiscordProvider } = await import("./provider.js");
 
-    resolveDiscordAccountMock.mockImplementation(() => ({
-      accountId: "default",
-      token: "cfg-token",
-      config: {
-        commands: { native: true, nativeSkills: false },
-        voice: { enabled: false },
-        agentComponents: { enabled: false },
-        execApprovals: { enabled: false },
-        inboundWorker: { runTimeoutMs: 300_000 },
-      },
-    }));
+    mockResolvedDiscordAccountConfig({
+      inboundWorker: { runTimeoutMs: 300_000 },
+    });
 
     await monitorDiscordProvider({
       config: baseConfig(),
       runtime: baseRuntime(),
     });
 
-    expect(createDiscordMessageHandlerMock).toHaveBeenCalledTimes(1);
-    const firstCall = createDiscordMessageHandlerMock.mock.calls.at(0) as
-      | [{ workerRunTimeoutMs?: number }]
-      | undefined;
-    const params = firstCall?.[0];
+    const params = getFirstDiscordMessageHandlerParams<{
+      workerRunTimeoutMs?: number;
+    }>();
     expect(params?.workerRunTimeoutMs).toBe(300_000);
   });