From 6a44ca9f7668c6e5753c43351eb64c7aa5847359 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 13 Mar 2026 22:34:42 +0000
Subject: [PATCH] test: dedupe discord queue preflight setup

---
 .../monitor/message-handler.queue.test.ts     | 43 +++++++++----------
 1 file changed, 21 insertions(+), 22 deletions(-)

diff --git a/src/discord/monitor/message-handler.queue.test.ts b/src/discord/monitor/message-handler.queue.test.ts
index 122ce852333..92cf0e31183 100644
--- a/src/discord/monitor/message-handler.queue.test.ts
+++ b/src/discord/monitor/message-handler.queue.test.ts
@@ -45,20 +45,30 @@ function createPreflightContext(channelId = "ch-1") {
   return createDiscordPreflightContext(channelId);
 }
 
+function createHandlerWithDefaultPreflight(overrides?: {
+  setStatus?: SetStatusFn;
+  workerRunTimeoutMs?: number;
+}) {
+  preflightDiscordMessageMock.mockImplementation(async (params: { data: { channel_id: string } }) =>
+    createPreflightContext(params.data.channel_id),
+  );
+  return createDiscordMessageHandler(createDiscordHandlerParams(overrides));
+}
+
 async function createLifecycleStopScenario(params: {
   createHandler: (status: SetStatusFn) => {
     handler: (data: never, opts: never) => Promise<void>;
     stop: () => void;
   };
 }) {
+  preflightDiscordMessageMock.mockImplementation(
+    async (preflightParams: { data: { channel_id: string } }) =>
+      createPreflightContext(preflightParams.data.channel_id),
+  );
   const runInFlight = createDeferred();
   processDiscordMessageMock.mockImplementation(async () => {
     await runInFlight.promise;
   });
-  preflightDiscordMessageMock.mockImplementation(
-    async (contextParams: { data: { channel_id: string } }) =>
-      createPreflightContext(contextParams.data.channel_id),
-  );
 
   const setStatus = vi.fn<SetStatusFn>();
   const { handler, stop } = params.createHandler(setStatus);
@@ -111,13 +121,8 @@ describe("createDiscordMessageHandler queue behavior", () => {
       .mockImplementationOnce(async () => {
         await secondRun.promise;
       });
-    preflightDiscordMessageMock.mockImplementation(
-      async (params: { data: { channel_id: string } }) =>
-        createPreflightContext(params.data.channel_id),
-    );
-
     const setStatus = vi.fn();
-    const handler = createDiscordMessageHandler(createDiscordHandlerParams({ setStatus }));
+    const handler = createHandlerWithDefaultPreflight({ setStatus });
 
     await expect(handler(createMessageData("m-1") as never, {} as never)).resolves.toBeUndefined();
 
@@ -175,12 +180,11 @@ describe("createDiscordMessageHandler queue behavior", () => {
           });
         })
         .mockImplementationOnce(async () => undefined);
-      preflightDiscordMessageMock.mockImplementation(
-        async (params: { data: { channel_id: string } }) =>
-          createPreflightContext(params.data.channel_id),
-      );
-
       const params = createDiscordHandlerParams({ workerRunTimeoutMs: 50 });
+      preflightDiscordMessageMock.mockImplementation(
+        async (preflightParams: { data: { channel_id: string } }) =>
+          createPreflightContext(preflightParams.data.channel_id),
+      );
       const handler = createDiscordMessageHandler(params);
 
       await expect(
@@ -226,13 +230,8 @@ describe("createDiscordMessageHandler queue behavior", () => {
           });
         },
       );
-      preflightDiscordMessageMock.mockImplementation(
-        async (params: { data: { channel_id: string } }) =>
-          createPreflightContext(params.data.channel_id),
-      );
-
       const params = createDiscordHandlerParams({ workerRunTimeoutMs: 0 });
-      const handler = createDiscordMessageHandler(params);
+      const handler = createHandlerWithDefaultPreflight({ workerRunTimeoutMs: 0 });
 
       await expect(
         handler(createMessageData("m-1") as never, {} as never),
@@ -442,7 +441,7 @@ describe("createDiscordMessageHandler queue behavior", () => {
     );
 
     const setStatus = vi.fn();
-    const handler = createDiscordMessageHandler(createDiscordHandlerParams({ setStatus }));
+    const handler = createHandlerWithDefaultPreflight({ setStatus });
 
     await expect(handler(createMessageData("m-1") as never, {} as never)).resolves.toBeUndefined();
     await expect(handler(createMessageData("m-2") as never, {} as never)).resolves.toBeUndefined();