test: share lifecycle config guard helpers

src/cli/daemon-cli/lifecycle-core.config-guard.test.ts

@@ -27,6 +27,28 @@ vi.mock("../../runtime.js", () => ({
   defaultRuntime,
 }));
 
+function setConfigSnapshot(params: {
+  exists: boolean;
+  valid: boolean;
+  issues?: Array<{ path: string; message: string }>;
+}) {
+  readConfigFileSnapshotMock.mockResolvedValue({
+    exists: params.exists,
+    valid: params.valid,
+    config: {},
+    issues: params.issues ?? [],
+  });
+}
+
+function createServiceRunArgs() {
+  return {
+    serviceNoun: "Gateway",
+    service,
+    renderStartHints: () => [],
+    opts: { json: true },
+  };
+}
+
 describe("runServiceRestart config pre-flight (#35862)", () => {
   let runServiceRestart: typeof import("./lifecycle-core.js").runServiceRestart;
 
@@ -37,12 +59,7 @@ describe("runServiceRestart config pre-flight (#35862)", () => {
   beforeEach(() => {
     resetLifecycleRuntimeLogs();
     readConfigFileSnapshotMock.mockReset();
-    readConfigFileSnapshotMock.mockResolvedValue({
+    setConfigSnapshot({ exists: true, valid: true });
-      exists: true,
-      valid: true,
-      config: {},
-      issues: [],
-    });
     loadConfig.mockReset();
     loadConfig.mockReturnValue({});
     resetLifecycleServiceMocks();
@@ -50,58 +67,30 @@ describe("runServiceRestart config pre-flight (#35862)", () => {
   });
 
   it("aborts restart when config is invalid", async () => {
-    readConfigFileSnapshotMock.mockResolvedValue({
+    setConfigSnapshot({
       exists: true,
       valid: false,
-      config: {},
       issues: [{ path: "agents.defaults.pdfModel", message: "Unrecognized key" }],
     });
 
-    await expect(
+    await expect(runServiceRestart(createServiceRunArgs())).rejects.toThrow("__exit__:1");
-      runServiceRestart({
-        serviceNoun: "Gateway",
-        service,
-        renderStartHints: () => [],
-        opts: { json: true },
-      }),
-    ).rejects.toThrow("__exit__:1");
 
     expect(service.restart).not.toHaveBeenCalled();
   });
 
   it("proceeds with restart when config is valid", async () => {
-    readConfigFileSnapshotMock.mockResolvedValue({
+    setConfigSnapshot({ exists: true, valid: true });
-      exists: true,
-      valid: true,
-      config: {},
-      issues: [],
-    });
 
-    const result = await runServiceRestart({
+    const result = await runServiceRestart(createServiceRunArgs());
-      serviceNoun: "Gateway",
-      service,
-      renderStartHints: () => [],
-      opts: { json: true },
-    });
 
     expect(result).toBe(true);
     expect(service.restart).toHaveBeenCalledTimes(1);
   });
 
   it("proceeds with restart when config file does not exist", async () => {
-    readConfigFileSnapshotMock.mockResolvedValue({
+    setConfigSnapshot({ exists: false, valid: true });
-      exists: false,
-      valid: true,
-      config: {},
-      issues: [],
-    });
 
-    const result = await runServiceRestart({
+    const result = await runServiceRestart(createServiceRunArgs());
-      serviceNoun: "Gateway",
-      service,
-      renderStartHints: () => [],
-      opts: { json: true },
-    });
 
     expect(result).toBe(true);
     expect(service.restart).toHaveBeenCalledTimes(1);
@@ -110,12 +99,7 @@ describe("runServiceRestart config pre-flight (#35862)", () => {
   it("proceeds with restart when snapshot read throws", async () => {
     readConfigFileSnapshotMock.mockRejectedValue(new Error("read failed"));
 
-    const result = await runServiceRestart({
+    const result = await runServiceRestart(createServiceRunArgs());
-      serviceNoun: "Gateway",
-      service,
-      renderStartHints: () => [],
-      opts: { json: true },
-    });
 
     expect(result).toBe(true);
     expect(service.restart).toHaveBeenCalledTimes(1);
@@ -132,49 +116,26 @@ describe("runServiceStart config pre-flight (#35862)", () => {
   beforeEach(() => {
     resetLifecycleRuntimeLogs();
     readConfigFileSnapshotMock.mockReset();
-    readConfigFileSnapshotMock.mockResolvedValue({
+    setConfigSnapshot({ exists: true, valid: true });
-      exists: true,
-      valid: true,
-      config: {},
-      issues: [],
-    });
     resetLifecycleServiceMocks();
   });
 
   it("aborts start when config is invalid", async () => {
-    readConfigFileSnapshotMock.mockResolvedValue({
+    setConfigSnapshot({
       exists: true,
       valid: false,
-      config: {},
       issues: [{ path: "agents.defaults.pdfModel", message: "Unrecognized key" }],
     });
 
-    await expect(
+    await expect(runServiceStart(createServiceRunArgs())).rejects.toThrow("__exit__:1");
-      runServiceStart({
-        serviceNoun: "Gateway",
-        service,
-        renderStartHints: () => [],
-        opts: { json: true },
-      }),
-    ).rejects.toThrow("__exit__:1");
 
     expect(service.restart).not.toHaveBeenCalled();
   });
 
   it("proceeds with start when config is valid", async () => {
-    readConfigFileSnapshotMock.mockResolvedValue({
+    setConfigSnapshot({ exists: true, valid: true });
-      exists: true,
-      valid: true,
-      config: {},
-      issues: [],
-    });
 
-    await runServiceStart({
+    await runServiceStart(createServiceRunArgs());
-      serviceNoun: "Gateway",
-      service,
-      renderStartHints: () => [],
-      opts: { json: true },
-    });
 
     expect(service.restart).toHaveBeenCalledTimes(1);
   });