From 5ca26bcae0d5d2035ef8d1f1ca017a9155149919 Mon Sep 17 00:00:00 2001
From: Vincent Koc <vincentkoc@ieee.org>
Date: Mon, 16 Mar 2026 00:04:47 -0700
Subject: [PATCH] Tests: add plugin loader contract suite

---
 src/plugins/contracts/loader.contract.test.ts | 114 ++++++++++++++++++
 1 file changed, 114 insertions(+)
 create mode 100644 src/plugins/contracts/loader.contract.test.ts

diff --git a/src/plugins/contracts/loader.contract.test.ts b/src/plugins/contracts/loader.contract.test.ts
new file mode 100644
index 00000000000..a1f82f56fda
--- /dev/null
+++ b/src/plugins/contracts/loader.contract.test.ts
@@ -0,0 +1,114 @@
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import { providerContractRegistry, webSearchProviderContractRegistry } from "./registry.js";
+
+const loadOpenClawPluginsMock = vi.fn();
+
+vi.mock("../loader.js", () => ({
+  loadOpenClawPlugins: (...args: unknown[]) => loadOpenClawPluginsMock(...args),
+}));
+
+const { resolvePluginProviders } = await import("../providers.js");
+const { resolvePluginWebSearchProviders } = await import("../web-search-providers.js");
+
+function uniqueSortedPluginIds(values: string[]) {
+  return [...new Set(values)].toSorted((left, right) => left.localeCompare(right));
+}
+
+describe("plugin loader contract", () => {
+  beforeEach(() => {
+    loadOpenClawPluginsMock.mockReset();
+    loadOpenClawPluginsMock.mockReturnValue({
+      providers: [],
+      webSearchProviders: [],
+    });
+  });
+
+  it("keeps bundled provider compatibility wired to the provider registry", () => {
+    const providerPluginIds = uniqueSortedPluginIds(
+      providerContractRegistry.map((entry) => entry.pluginId),
+    );
+
+    resolvePluginProviders({
+      bundledProviderAllowlistCompat: true,
+      config: {
+        plugins: {
+          allow: ["openrouter"],
+        },
+      },
+    });
+
+    expect(loadOpenClawPluginsMock).toHaveBeenCalledWith(
+      expect.objectContaining({
+        config: expect.objectContaining({
+          plugins: expect.objectContaining({
+            allow: expect.arrayContaining(providerPluginIds),
+          }),
+        }),
+      }),
+    );
+  });
+
+  it("keeps vitest bundled provider enablement wired to the provider registry", () => {
+    const providerPluginIds = uniqueSortedPluginIds(
+      providerContractRegistry.map((entry) => entry.pluginId),
+    );
+
+    resolvePluginProviders({
+      bundledProviderVitestCompat: true,
+      env: { VITEST: "1" } as NodeJS.ProcessEnv,
+    });
+
+    expect(loadOpenClawPluginsMock).toHaveBeenCalledWith(
+      expect.objectContaining({
+        config: expect.objectContaining({
+          plugins: expect.objectContaining({
+            enabled: true,
+            allow: expect.arrayContaining(providerPluginIds),
+          }),
+        }),
+      }),
+    );
+  });
+
+  it("keeps bundled web search loading scoped to the web search registry", () => {
+    const webSearchPluginIds = uniqueSortedPluginIds(
+      webSearchProviderContractRegistry.map((entry) => entry.pluginId),
+    );
+
+    resolvePluginWebSearchProviders({});
+
+    expect(loadOpenClawPluginsMock).toHaveBeenCalledWith(
+      expect.objectContaining({
+        onlyPluginIds: webSearchPluginIds,
+        activate: false,
+        cache: false,
+      }),
+    );
+  });
+
+  it("keeps bundled web search allowlist compatibility wired to the web search registry", () => {
+    const webSearchPluginIds = uniqueSortedPluginIds(
+      webSearchProviderContractRegistry.map((entry) => entry.pluginId),
+    );
+
+    resolvePluginWebSearchProviders({
+      bundledAllowlistCompat: true,
+      config: {
+        plugins: {
+          allow: ["openrouter"],
+        },
+      },
+    });
+
+    expect(loadOpenClawPluginsMock).toHaveBeenCalledWith(
+      expect.objectContaining({
+        config: expect.objectContaining({
+          plugins: expect.objectContaining({
+            allow: expect.arrayContaining(webSearchPluginIds),
+          }),
+        }),
+        onlyPluginIds: webSearchPluginIds,
+      }),
+    );
+  });
+});