diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6dc68d2275a..c7bacc8504f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -330,6 +330,9 @@ jobs: - name: Smoke test CLI launcher status json run: node openclaw.mjs status --json --timeout 1 + - name: Smoke test built bundled plugin singleton + run: pnpm test:build:singleton + - name: Check CLI startup memory run: pnpm test:startup:memory diff --git a/package.json b/package.json index 473a4fcfefe..5dc22fb6bea 100644 --- a/package.json +++ b/package.json @@ -564,6 +564,7 @@ "test": "node scripts/test-parallel.mjs", "test:all": "pnpm lint && pnpm build && pnpm test && pnpm test:e2e && pnpm test:live && pnpm test:docker:all", "test:auth:compat": "vitest run --config vitest.gateway.config.ts src/gateway/server.auth.compat-baseline.test.ts src/gateway/client.test.ts src/gateway/reconnect-gating.test.ts src/gateway/protocol/connect-error-details.test.ts", + "test:build:singleton": "node scripts/test-built-plugin-singleton.mjs", "test:channels": "vitest run --config vitest.channels.config.ts", "test:contracts": "pnpm test:contracts:channels && pnpm test:contracts:plugins", "test:contracts:channels": "OPENCLAW_TEST_PROFILE=low pnpm test -- src/channels/plugins/contracts", diff --git a/scripts/test-built-plugin-singleton.mjs b/scripts/test-built-plugin-singleton.mjs new file mode 100644 index 00000000000..04e11c5f900 --- /dev/null +++ b/scripts/test-built-plugin-singleton.mjs @@ -0,0 +1,143 @@ +import assert from "node:assert/strict"; +import fs from "node:fs"; +import os from "node:os"; +import path from "node:path"; +import { fileURLToPath, pathToFileURL } from "node:url"; +import { stageBundledPluginRuntime } from "./stage-bundled-plugin-runtime.mjs"; + +const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), ".."); +const smokeEntryPath = path.join(repoRoot, "dist", "plugins", "build-smoke-entry.js"); +assert.ok(fs.existsSync(smokeEntryPath), `missing build output: ${smokeEntryPath}`); + +const { clearPluginCommands, getPluginCommandSpecs, loadOpenClawPlugins, matchPluginCommand } = + await import(pathToFileURL(smokeEntryPath).href); + +assert.equal(typeof loadOpenClawPlugins, "function", "built loader export missing"); +assert.equal(typeof clearPluginCommands, "function", "clearPluginCommands missing"); +assert.equal(typeof getPluginCommandSpecs, "function", "getPluginCommandSpecs missing"); +assert.equal(typeof matchPluginCommand, "function", "matchPluginCommand missing"); + +const tempRoot = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-build-smoke-")); + +function cleanup() { + clearPluginCommands(); + fs.rmSync(tempRoot, { recursive: true, force: true }); +} + +process.on("exit", cleanup); +process.on("SIGINT", () => { + cleanup(); + process.exit(130); +}); +process.on("SIGTERM", () => { + cleanup(); + process.exit(143); +}); + +const pluginId = "build-smoke-plugin"; +const distPluginDir = path.join(tempRoot, "dist", "extensions", pluginId); +fs.mkdirSync(distPluginDir, { recursive: true }); +fs.writeFileSync(path.join(tempRoot, "package.json"), '{ "type": "module" }\n', "utf8"); +fs.writeFileSync( + path.join(distPluginDir, "package.json"), + JSON.stringify( + { + name: "@openclaw/build-smoke-plugin", + type: "module", + openclaw: { + extensions: ["./index.js"], + }, + }, + null, + 2, + ), + "utf8", +); +fs.writeFileSync( + path.join(distPluginDir, "openclaw.plugin.json"), + JSON.stringify( + { + id: pluginId, + configSchema: { + type: "object", + additionalProperties: false, + properties: {}, + }, + }, + null, + 2, + ), + "utf8", +); +fs.writeFileSync( + path.join(distPluginDir, "index.js"), + [ + "import sdk from 'openclaw/plugin-sdk';", + "const { emptyPluginConfigSchema } = sdk;", + "", + "export default {", + ` id: ${JSON.stringify(pluginId)},`, + " configSchema: emptyPluginConfigSchema(),", + " register(api) {", + " api.registerCommand({", + " name: 'pair',", + " description: 'Pair a device',", + " acceptsArgs: true,", + " nativeNames: { telegram: 'pair', discord: 'pair' },", + " async handler({ args }) {", + " return { text: `paired:${args ?? ''}` };", + " },", + " });", + " },", + "};", + "", + ].join("\n"), + "utf8", +); + +stageBundledPluginRuntime({ repoRoot: tempRoot }); + +const runtimeEntryPath = path.join(tempRoot, "dist-runtime", "extensions", pluginId, "index.js"); +assert.ok(fs.existsSync(runtimeEntryPath), "runtime overlay entry missing"); +assert.equal( + fs.existsSync(path.join(tempRoot, "dist-runtime", "plugins", "commands.js")), + false, + "dist-runtime must not stage a duplicate commands module", +); + +clearPluginCommands(); + +const registry = loadOpenClawPlugins({ + cache: false, + workspaceDir: tempRoot, + env: { + ...process.env, + OPENCLAW_BUNDLED_PLUGINS_DIR: path.join(tempRoot, "dist-runtime", "extensions"), + OPENCLAW_DISABLE_PLUGIN_DISCOVERY_CACHE: "1", + }, + config: { + plugins: { + enabled: true, + allow: [pluginId], + entries: { + [pluginId]: { enabled: true }, + }, + }, + }, +}); + +const record = registry.plugins.find((entry) => entry.id === pluginId); +assert.ok(record, "smoke plugin missing from registry"); +assert.equal(record.status, "loaded", record.error ?? "smoke plugin failed to load"); + +assert.deepEqual(getPluginCommandSpecs("telegram"), [ + { name: "pair", description: "Pair a device", acceptsArgs: true }, +]); + +const match = matchPluginCommand("/pair now"); +assert.ok(match, "canonical built command registry did not receive the command"); +assert.equal(match.args, "now"); +const result = await match.command.handler({ args: match.args }); +assert.deepEqual(result, { text: "paired:now" }); + +process.stdout.write("[build-smoke] built plugin singleton smoke passed\n"); diff --git a/src/plugins/build-smoke-entry.ts b/src/plugins/build-smoke-entry.ts new file mode 100644 index 00000000000..c4604dedfeb --- /dev/null +++ b/src/plugins/build-smoke-entry.ts @@ -0,0 +1,7 @@ +export { + clearPluginCommands, + executePluginCommand, + getPluginCommandSpecs, + matchPluginCommand, +} from "./commands.js"; +export { loadOpenClawPlugins } from "./loader.js"; diff --git a/tsdown.config.ts b/tsdown.config.ts index 966e12afc10..48e69927f98 100644 --- a/tsdown.config.ts +++ b/tsdown.config.ts @@ -171,6 +171,7 @@ function buildCoreDistEntries(): Record { "line/accounts": "src/line/accounts.ts", "line/send": "src/line/send.ts", "line/template-messages": "src/line/template-messages.ts", + "plugins/build-smoke-entry": "src/plugins/build-smoke-entry.ts", "plugins/runtime/index": "src/plugins/runtime/index.ts", "llm-slug-generator": "src/hooks/llm-slug-generator.ts", };