From 4ec0a120dfddf6f1770807fa18a1cc88202db725 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 13 Mar 2026 21:04:20 +0000
Subject: [PATCH] test: share zalo api request assertion

---
 extensions/zalo/src/api.test.ts | 35 ++++++++++++++-------------------
 1 file changed, 15 insertions(+), 20 deletions(-)

diff --git a/extensions/zalo/src/api.test.ts b/extensions/zalo/src/api.test.ts
index 00198f5072e..ffdeab84ae4 100644
--- a/extensions/zalo/src/api.test.ts
+++ b/extensions/zalo/src/api.test.ts
@@ -1,31 +1,26 @@
 import { describe, expect, it, vi } from "vitest";
 import { deleteWebhook, getWebhookInfo, sendChatAction, type ZaloFetch } from "./api.js";
 
+function createOkFetcher() {
+  return vi.fn<ZaloFetch>(async () => new Response(JSON.stringify({ ok: true, result: {} })));
+}
+
+async function expectPostJsonRequest(run: (token: string, fetcher: ZaloFetch) => Promise<unknown>) {
+  const fetcher = createOkFetcher();
+  await run("test-token", fetcher);
+  expect(fetcher).toHaveBeenCalledTimes(1);
+  const [, init] = fetcher.mock.calls[0] ?? [];
+  expect(init?.method).toBe("POST");
+  expect(init?.headers).toEqual({ "Content-Type": "application/json" });
+}
+
 describe("Zalo API request methods", () => {
   it("uses POST for getWebhookInfo", async () => {
-    const fetcher = vi.fn<ZaloFetch>(
-      async () => new Response(JSON.stringify({ ok: true, result: {} })),
-    );
-
-    await getWebhookInfo("test-token", fetcher);
-
-    expect(fetcher).toHaveBeenCalledTimes(1);
-    const [, init] = fetcher.mock.calls[0] ?? [];
-    expect(init?.method).toBe("POST");
-    expect(init?.headers).toEqual({ "Content-Type": "application/json" });
+    await expectPostJsonRequest(getWebhookInfo);
   });
 
   it("keeps POST for deleteWebhook", async () => {
-    const fetcher = vi.fn<ZaloFetch>(
-      async () => new Response(JSON.stringify({ ok: true, result: {} })),
-    );
-
-    await deleteWebhook("test-token", fetcher);
-
-    expect(fetcher).toHaveBeenCalledTimes(1);
-    const [, init] = fetcher.mock.calls[0] ?? [];
-    expect(init?.method).toBe("POST");
-    expect(init?.headers).toEqual({ "Content-Type": "application/json" });
+    await expectPostJsonRequest(deleteWebhook);
   });
 
   it("aborts sendChatAction when the typing timeout elapses", async () => {