From 415e7d941be076e412d46f5784cbb8bbda242bc9 Mon Sep 17 00:00:00 2001 From: Vincent Koc Date: Tue, 31 Mar 2026 21:01:18 +0900 Subject: [PATCH] test(slack): remove slash metadata polling --- extensions/slack/src/monitor/slash.test.ts | 11 +++++++---- test/fixtures/test-timings.channels.json | 2 +- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/extensions/slack/src/monitor/slash.test.ts b/extensions/slack/src/monitor/slash.test.ts index c912325181a..f56f4bfdece 100644 --- a/extensions/slack/src/monitor/slash.test.ts +++ b/extensions/slack/src/monitor/slash.test.ts @@ -979,8 +979,12 @@ describe("slack slash command session metadata", () => { }); it("awaits session metadata persistence before dispatch", async () => { + const recordStarted = createDeferred(); const deferred = createDeferred(); - recordSessionMetaFromInboundMock.mockClear().mockReturnValue(deferred.promise); + recordSessionMetaFromInboundMock.mockClear().mockImplementation(() => { + recordStarted.resolve(); + return deferred.promise; + }); const harness = createPolicyHarness({ groupPolicy: "open" }); await registerCommands(harness.ctx, harness.account); @@ -993,9 +997,8 @@ describe("slack slash command session metadata", () => { }, }); - await vi.waitFor(() => { - expect(recordSessionMetaFromInboundMock).toHaveBeenCalledTimes(1); - }); + await recordStarted.promise; + expect(recordSessionMetaFromInboundMock).toHaveBeenCalledTimes(1); expect(dispatchMock).not.toHaveBeenCalled(); deferred.resolve(); diff --git a/test/fixtures/test-timings.channels.json b/test/fixtures/test-timings.channels.json index f9bb9cf30fc..99359c44436 100644 --- a/test/fixtures/test-timings.channels.json +++ b/test/fixtures/test-timings.channels.json @@ -73,7 +73,7 @@ "durationMs": 2900 }, "extensions/slack/src/monitor/slash.test.ts": { - "durationMs": 2800 + "durationMs": 12500 }, "extensions/whatsapp/src/send.test.ts": { "durationMs": 2700