mirror of https://github.com/openclaw/openclaw.git
fix: honor zalo setup dm policy accounts
This commit is contained in:
parent
41ce3269f4
commit
4107a5a4f0
|
|
@ -1,11 +1,15 @@
|
|||
import {
|
||||
addWildcardAllowFrom,
|
||||
createDelegatedSetupWizardProxy,
|
||||
createPatchedAccountSetupAdapter,
|
||||
createSetupInputPresenceValidator,
|
||||
createTopLevelChannelDmPolicy,
|
||||
type ChannelSetupWizard,
|
||||
type ChannelSetupDmPolicy,
|
||||
DEFAULT_ACCOUNT_ID,
|
||||
normalizeAccountId,
|
||||
} from "openclaw/plugin-sdk/setup";
|
||||
import type { OpenClawConfig } from "./runtime-api.js";
|
||||
import { resolveDefaultZaloAccountId, resolveZaloAccount } from "./accounts.js";
|
||||
|
||||
const channel = "zalo" as const;
|
||||
|
||||
|
|
@ -30,15 +34,76 @@ export const zaloSetupAdapter = createPatchedAccountSetupAdapter({
|
|||
: {},
|
||||
});
|
||||
|
||||
export const zaloDmPolicy = createTopLevelChannelDmPolicy({
|
||||
export const zaloDmPolicy: ChannelSetupDmPolicy = {
|
||||
label: "Zalo",
|
||||
channel,
|
||||
policyKey: "channels.zalo.dmPolicy",
|
||||
allowFromKey: "channels.zalo.allowFrom",
|
||||
getCurrent: (cfg) => cfg.channels?.zalo?.dmPolicy ?? "pairing",
|
||||
resolveConfigKeys: (_cfg, accountId) =>
|
||||
accountId && accountId !== DEFAULT_ACCOUNT_ID
|
||||
? {
|
||||
policyKey: `channels.zalo.accounts.${accountId}.dmPolicy`,
|
||||
allowFromKey: `channels.zalo.accounts.${accountId}.allowFrom`,
|
||||
}
|
||||
: {
|
||||
policyKey: "channels.zalo.dmPolicy",
|
||||
allowFromKey: "channels.zalo.allowFrom",
|
||||
},
|
||||
getCurrent: (cfg, accountId) =>
|
||||
resolveZaloAccount({
|
||||
cfg: cfg as OpenClawConfig,
|
||||
accountId: accountId ?? DEFAULT_ACCOUNT_ID,
|
||||
}).config.dmPolicy ?? "pairing",
|
||||
setPolicy: (cfg, policy, accountId) => {
|
||||
const resolvedAccountId =
|
||||
accountId && normalizeAccountId(accountId)
|
||||
? (normalizeAccountId(accountId) ?? DEFAULT_ACCOUNT_ID)
|
||||
: resolveDefaultZaloAccountId(cfg as OpenClawConfig);
|
||||
const resolved = resolveZaloAccount({
|
||||
cfg: cfg as OpenClawConfig,
|
||||
accountId: resolvedAccountId,
|
||||
});
|
||||
if (resolvedAccountId === DEFAULT_ACCOUNT_ID) {
|
||||
return {
|
||||
...cfg,
|
||||
channels: {
|
||||
...cfg.channels,
|
||||
zalo: {
|
||||
...cfg.channels?.zalo,
|
||||
enabled: true,
|
||||
dmPolicy: policy,
|
||||
...(policy === "open"
|
||||
? { allowFrom: addWildcardAllowFrom(resolved.config.allowFrom) }
|
||||
: {}),
|
||||
},
|
||||
},
|
||||
};
|
||||
}
|
||||
return {
|
||||
...cfg,
|
||||
channels: {
|
||||
...cfg.channels,
|
||||
zalo: {
|
||||
...cfg.channels?.zalo,
|
||||
enabled: true,
|
||||
accounts: {
|
||||
...cfg.channels?.zalo?.accounts,
|
||||
[resolvedAccountId]: {
|
||||
...cfg.channels?.zalo?.accounts?.[resolvedAccountId],
|
||||
enabled: cfg.channels?.zalo?.accounts?.[resolvedAccountId]?.enabled ?? true,
|
||||
dmPolicy: policy,
|
||||
...(policy === "open"
|
||||
? { allowFrom: addWildcardAllowFrom(resolved.config.allowFrom) }
|
||||
: {}),
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
};
|
||||
},
|
||||
promptAllowFrom: async (params) =>
|
||||
(await loadZaloSetupWizard()).dmPolicy?.promptAllowFrom?.(params) ?? params.cfg,
|
||||
});
|
||||
};
|
||||
|
||||
async function loadZaloSetupWizard(): Promise<ChannelSetupWizard> {
|
||||
return (await import("./setup-surface.js")).zaloSetupWizard;
|
||||
|
|
|
|||
|
|
@ -7,6 +7,7 @@ import {
|
|||
} from "../../../test/helpers/plugins/setup-wizard.js";
|
||||
import type { OpenClawConfig } from "../runtime-api.js";
|
||||
import { zaloPlugin } from "./channel.js";
|
||||
import { zaloDmPolicy } from "./setup-core.js";
|
||||
|
||||
const zaloConfigure = createPluginSetupWizardConfigure(zaloPlugin);
|
||||
|
||||
|
|
@ -40,4 +41,55 @@ describe("zalo setup wizard", () => {
|
|||
expect(result.cfg.channels?.zalo?.botToken).toBe("12345689:abc-xyz");
|
||||
expect(result.cfg.channels?.zalo?.webhookUrl).toBeUndefined();
|
||||
});
|
||||
|
||||
it("reads the named-account DM policy instead of the channel root", () => {
|
||||
expect(
|
||||
zaloDmPolicy.getCurrent(
|
||||
{
|
||||
channels: {
|
||||
zalo: {
|
||||
dmPolicy: "disabled",
|
||||
accounts: {
|
||||
work: {
|
||||
botToken: "12345689:abc-xyz",
|
||||
dmPolicy: "allowlist",
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
} as OpenClawConfig,
|
||||
"work",
|
||||
),
|
||||
).toBe("allowlist");
|
||||
});
|
||||
|
||||
it("reports account-scoped config keys for named accounts", () => {
|
||||
expect(zaloDmPolicy.resolveConfigKeys?.({} as OpenClawConfig, "work")).toEqual({
|
||||
policyKey: "channels.zalo.accounts.work.dmPolicy",
|
||||
allowFromKey: "channels.zalo.accounts.work.allowFrom",
|
||||
});
|
||||
});
|
||||
|
||||
it('writes open policy state to the named account and preserves inherited allowFrom with "*"', () => {
|
||||
const next = zaloDmPolicy.setPolicy(
|
||||
{
|
||||
channels: {
|
||||
zalo: {
|
||||
allowFrom: ["123456789"],
|
||||
accounts: {
|
||||
work: {
|
||||
botToken: "12345689:abc-xyz",
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
} as OpenClawConfig,
|
||||
"open",
|
||||
"work",
|
||||
);
|
||||
|
||||
expect(next.channels?.zalo?.dmPolicy).toBeUndefined();
|
||||
expect(next.channels?.zalo?.accounts?.work?.dmPolicy).toBe("open");
|
||||
expect(next.channels?.zalo?.accounts?.work?.allowFrom).toEqual(["123456789", "*"]);
|
||||
});
|
||||
});
|
||||
|
|
|
|||
|
|
@ -1,6 +1,5 @@
|
|||
import {
|
||||
buildSingleChannelSecretPromptState,
|
||||
createTopLevelChannelDmPolicy,
|
||||
createStandardChannelSetupStatus,
|
||||
DEFAULT_ACCOUNT_ID,
|
||||
formatDocsLink,
|
||||
|
|
@ -15,7 +14,7 @@ import {
|
|||
type SecretInput,
|
||||
} from "openclaw/plugin-sdk/setup";
|
||||
import { listZaloAccountIds, resolveDefaultZaloAccountId, resolveZaloAccount } from "./accounts.js";
|
||||
import { zaloSetupAdapter } from "./setup-core.js";
|
||||
import { zaloDmPolicy, zaloSetupAdapter } from "./setup-core.js";
|
||||
|
||||
const channel = "zalo" as const;
|
||||
|
||||
|
|
@ -173,25 +172,6 @@ async function promptZaloAllowFrom(params: {
|
|||
} as OpenClawConfig;
|
||||
}
|
||||
|
||||
const zaloDmPolicy: ChannelSetupDmPolicy = createTopLevelChannelDmPolicy({
|
||||
label: "Zalo",
|
||||
channel,
|
||||
policyKey: "channels.zalo.dmPolicy",
|
||||
allowFromKey: "channels.zalo.allowFrom",
|
||||
getCurrent: (cfg) => (cfg.channels?.zalo?.dmPolicy ?? "pairing") as "pairing",
|
||||
promptAllowFrom: async ({ cfg, prompter, accountId }) => {
|
||||
const id =
|
||||
accountId && normalizeAccountId(accountId)
|
||||
? (normalizeAccountId(accountId) ?? DEFAULT_ACCOUNT_ID)
|
||||
: resolveDefaultZaloAccountId(cfg as OpenClawConfig);
|
||||
return await promptZaloAllowFrom({
|
||||
cfg: cfg as OpenClawConfig,
|
||||
prompter,
|
||||
accountId: id,
|
||||
});
|
||||
},
|
||||
});
|
||||
|
||||
export { zaloSetupAdapter } from "./setup-core.js";
|
||||
|
||||
export const zaloSetupWizard: ChannelSetupWizard = {
|
||||
|
|
|
|||
Loading…
Reference in New Issue