From 2083b0581dbb6f094727f048e429506347ee9ab8 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Sat, 14 Mar 2026 00:42:13 +0000
Subject: [PATCH] test: tighten system run command normalization coverage

---
 src/infra/system-run-command.test.ts | 37 ++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/src/infra/system-run-command.test.ts b/src/infra/system-run-command.test.ts
index 4b8e8043eee..57244672c9b 100644
--- a/src/infra/system-run-command.test.ts
+++ b/src/infra/system-run-command.test.ts
@@ -96,6 +96,18 @@ describe("system run command helpers", () => {
     expect(res.commandText).toBe("echo hi");
   });
 
+  test("validateSystemRunCommandConsistency trims rawCommand before comparison", () => {
+    const res = validateSystemRunCommandConsistency({
+      argv: ["echo", "hi"],
+      rawCommand: "  echo hi  ",
+    });
+    expect(res.ok).toBe(true);
+    if (!res.ok) {
+      throw new Error("unreachable");
+    }
+    expect(res.commandText).toBe("echo hi");
+  });
+
   test("validateSystemRunCommandConsistency rejects mismatched rawCommand vs direct argv", () => {
     expectRawCommandMismatch({
       argv: ["uname", "-a"],
@@ -182,6 +194,18 @@ describe("system run command helpers", () => {
     expect(res.details?.code).toBe("MISSING_COMMAND");
   });
 
+  test("resolveSystemRunCommand treats non-array command values as missing", () => {
+    const res = resolveSystemRunCommand({
+      command: "echo hi",
+      rawCommand: "echo hi",
+    });
+    expect(res.ok).toBe(false);
+    if (res.ok) {
+      throw new Error("unreachable");
+    }
+    expect(res.details?.code).toBe("MISSING_COMMAND");
+  });
+
   test("resolveSystemRunCommand returns an empty success payload when no command is provided", () => {
     const res = resolveSystemRunCommand({});
     expect(res.ok).toBe(true);
@@ -206,6 +230,19 @@ describe("system run command helpers", () => {
     expect(res.commandText).toBe("echo 123 false null");
   });
 
+  test("resolveSystemRunCommandRequest trims legacy rawCommand shell payloads", () => {
+    const res = resolveSystemRunCommandRequest({
+      command: ["/bin/sh", "-lc", "echo hi"],
+      rawCommand: "  echo hi  ",
+    });
+    expect(res.ok).toBe(true);
+    if (!res.ok) {
+      throw new Error("unreachable");
+    }
+    expect(res.previewText).toBe("echo hi");
+    expect(res.commandText).toBe('/bin/sh -lc "echo hi"');
+  });
+
   test("resolveSystemRunCommandRequest accepts legacy shell payloads but returns canonical command text", () => {
     const res = resolveSystemRunCommandRequest({
       command: ["cmd.exe", "/d", "/s", "/c", "echo", "SAFE&&whoami"],