From 1ea85a5d0bab4272c8babdb136f2d8c80b22b16b Mon Sep 17 00:00:00 2001 From: Gustavo Madeira Santana Date: Mon, 30 Mar 2026 13:16:21 -0400 Subject: [PATCH] Matrix: remove stale monitor mention regex param --- extensions/matrix/src/matrix/monitor/handler.test-helpers.ts | 3 +-- extensions/matrix/src/matrix/monitor/handler.test.ts | 4 +++- extensions/matrix/src/matrix/monitor/handler.ts | 2 -- extensions/matrix/src/matrix/monitor/index.ts | 2 -- 4 files changed, 4 insertions(+), 7 deletions(-) diff --git a/extensions/matrix/src/matrix/monitor/handler.test-helpers.ts b/extensions/matrix/src/matrix/monitor/handler.test-helpers.ts index 5bd3caf40cd..88a8055b437 100644 --- a/extensions/matrix/src/matrix/monitor/handler.test-helpers.ts +++ b/extensions/matrix/src/matrix/monitor/handler.test-helpers.ts @@ -26,7 +26,7 @@ type MatrixHandlerTestHarnessOptions = { roomsConfig?: Record; accountAllowBots?: boolean | "mentions"; configuredBotUserIds?: Set; - mentionRegexes?: MatrixMonitorHandlerParams["mentionRegexes"]; + mentionRegexes?: RegExp[]; groupPolicy?: "open" | "allowlist" | "disabled"; replyToMode?: ReplyToMode; threadReplies?: "off" | "inbound" | "always"; @@ -207,7 +207,6 @@ export function createMatrixHandlerTestHarness( roomsConfig: options.roomsConfig, accountAllowBots: options.accountAllowBots, configuredBotUserIds: options.configuredBotUserIds, - mentionRegexes: options.mentionRegexes ?? [], groupPolicy: options.groupPolicy ?? "open", replyToMode: options.replyToMode ?? "off", threadReplies: options.threadReplies ?? "inbound", diff --git a/extensions/matrix/src/matrix/monitor/handler.test.ts b/extensions/matrix/src/matrix/monitor/handler.test.ts index 7be3c23ffa8..c30061400b1 100644 --- a/extensions/matrix/src/matrix/monitor/handler.test.ts +++ b/extensions/matrix/src/matrix/monitor/handler.test.ts @@ -818,6 +818,9 @@ describe("matrix monitor handler pairing account scope", () => { matchedBy: "binding.account", }), }, + mentions: { + buildMentionRegexes: () => [], + }, session: { resolveStorePath: () => "/tmp/session-store", readSessionUpdatedAt: () => undefined, @@ -881,7 +884,6 @@ describe("matrix monitor handler pairing account scope", () => { } as never, logVerboseMessage: () => {}, allowFrom: [], - mentionRegexes: [], groupPolicy: "open", replyToMode: "off", threadReplies: "inbound", diff --git a/extensions/matrix/src/matrix/monitor/handler.ts b/extensions/matrix/src/matrix/monitor/handler.ts index 305d7f0a321..5fd8d97beb8 100644 --- a/extensions/matrix/src/matrix/monitor/handler.ts +++ b/extensions/matrix/src/matrix/monitor/handler.ts @@ -66,7 +66,6 @@ export type MatrixMonitorHandlerParams = { roomsConfig?: Record; accountAllowBots?: boolean | "mentions"; configuredBotUserIds?: ReadonlySet; - mentionRegexes: ReturnType; groupPolicy: "open" | "allowlist" | "disabled"; replyToMode: ReplyToMode; threadReplies: "off" | "inbound" | "always"; @@ -159,7 +158,6 @@ export function createMatrixRoomMessageHandler(params: MatrixMonitorHandlerParam roomsConfig, accountAllowBots, configuredBotUserIds = new Set(), - mentionRegexes, groupPolicy, replyToMode, threadReplies, diff --git a/extensions/matrix/src/matrix/monitor/index.ts b/extensions/matrix/src/matrix/monitor/index.ts index 9917ac7f309..4352107d3f7 100644 --- a/extensions/matrix/src/matrix/monitor/index.ts +++ b/extensions/matrix/src/matrix/monitor/index.ts @@ -164,7 +164,6 @@ export async function monitorMatrixProvider(opts: MonitorMatrixOpts = {}): Promi } }; - const mentionRegexes = core.channel.mentions.buildMentionRegexes(cfg); const defaultGroupPolicy = resolveDefaultGroupPolicy(cfg); const { groupPolicy: groupPolicyRaw, providerMissingFallbackApplied } = resolveAllowlistProviderRuntimeGroupPolicy({ @@ -225,7 +224,6 @@ export async function monitorMatrixProvider(opts: MonitorMatrixOpts = {}): Promi roomsConfig, accountAllowBots, configuredBotUserIds, - mentionRegexes, groupPolicy, replyToMode, threadReplies,