From 1a5a3fecf3f5d0c373da21adff5641856cb33b81 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 13 Mar 2026 20:16:02 +0000
Subject: [PATCH] refactor: share ollama setup test helpers

---
 src/commands/ollama-setup.test.ts | 51 +++++++++++++------------------
 1 file changed, 21 insertions(+), 30 deletions(-)

diff --git a/src/commands/ollama-setup.test.ts b/src/commands/ollama-setup.test.ts
index d1e50479096..09708296ee4 100644
--- a/src/commands/ollama-setup.test.ts
+++ b/src/commands/ollama-setup.test.ts
@@ -101,6 +101,21 @@ function createSignedOutRemoteFetchMock() {
   });
 }
 
+function createDefaultOllamaConfig(primary: string) {
+  return {
+    agents: { defaults: { model: { primary } } },
+    models: { providers: { ollama: { baseUrl: "http://127.0.0.1:11434", models: [] } } },
+  };
+}
+
+function createRuntime() {
+  return {
+    log: vi.fn(),
+    error: vi.fn(),
+    exit: vi.fn(),
+  } as unknown as RuntimeEnv;
+}
+
 describe("ollama setup", () => {
   afterEach(() => {
     vi.unstubAllGlobals();
@@ -242,10 +257,7 @@ describe("ollama setup", () => {
       vi.stubGlobal("fetch", fetchMock);
 
       await ensureOllamaModelPulled({
-        config: {
-          agents: { defaults: { model: { primary: "ollama/glm-4.7-flash" } } },
-          models: { providers: { ollama: { baseUrl: "http://127.0.0.1:11434", models: [] } } },
-        },
+        config: createDefaultOllamaConfig("ollama/glm-4.7-flash"),
         prompter,
       });
 
@@ -260,10 +272,7 @@ describe("ollama setup", () => {
       vi.stubGlobal("fetch", fetchMock);
 
       await ensureOllamaModelPulled({
-        config: {
-          agents: { defaults: { model: { primary: "ollama/glm-4.7-flash" } } },
-          models: { providers: { ollama: { baseUrl: "http://127.0.0.1:11434", models: [] } } },
-        },
+        config: createDefaultOllamaConfig("ollama/glm-4.7-flash"),
         prompter,
       });
 
@@ -276,10 +285,7 @@ describe("ollama setup", () => {
       vi.stubGlobal("fetch", fetchMock);
 
       await ensureOllamaModelPulled({
-        config: {
-          agents: { defaults: { model: { primary: "ollama/kimi-k2.5:cloud" } } },
-          models: { providers: { ollama: { baseUrl: "http://127.0.0.1:11434", models: [] } } },
-        },
+        config: createDefaultOllamaConfig("ollama/kimi-k2.5:cloud"),
         prompter,
       });
 
@@ -308,12 +314,7 @@ describe("ollama setup", () => {
       pullResponse: new Response('{"error":"disk full"}\n', { status: 200 }),
     });
     vi.stubGlobal("fetch", fetchMock);
-
-    const runtime = {
-      log: vi.fn(),
-      error: vi.fn(),
-      exit: vi.fn(),
-    } as unknown as RuntimeEnv;
+    const runtime = createRuntime();
 
     const result = await configureOllamaNonInteractive({
       nextConfig: {
@@ -346,12 +347,7 @@ describe("ollama setup", () => {
       pullResponse: new Response('{"status":"success"}\n', { status: 200 }),
     });
     vi.stubGlobal("fetch", fetchMock);
-
-    const runtime = {
-      log: vi.fn(),
-      error: vi.fn(),
-      exit: vi.fn(),
-    } as unknown as RuntimeEnv;
+    const runtime = createRuntime();
 
     const result = await configureOllamaNonInteractive({
       nextConfig: {},
@@ -372,12 +368,7 @@ describe("ollama setup", () => {
   it("accepts cloud models in non-interactive mode without pulling", async () => {
     const fetchMock = createOllamaFetchMock({ tags: [] });
     vi.stubGlobal("fetch", fetchMock);
-
-    const runtime = {
-      log: vi.fn(),
-      error: vi.fn(),
-      exit: vi.fn(),
-    } as unknown as RuntimeEnv;
+    const runtime = createRuntime();
 
     const result = await configureOllamaNonInteractive({
       nextConfig: {},