From 0652b885df33189bb0700ec2f695fb7ce5399652 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 13 Mar 2026 19:06:33 +0000
Subject: [PATCH] refactor: share gemini preview model fixtures

---
 ...ini-3-ids-preview-google-providers.test.ts | 124 ++++++++----------
 1 file changed, 58 insertions(+), 66 deletions(-)

diff --git a/src/agents/models-config.normalizes-gemini-3-ids-preview-google-providers.test.ts b/src/agents/models-config.normalizes-gemini-3-ids-preview-google-providers.test.ts
index 8414fb10d08..e10fcbc4ee4 100644
--- a/src/agents/models-config.normalizes-gemini-3-ids-preview-google-providers.test.ts
+++ b/src/agents/models-config.normalizes-gemini-3-ids-preview-google-providers.test.ts
@@ -4,88 +4,80 @@ import { installModelsConfigTestHooks, withModelsTempHome } from "./models-confi
 import { ensureOpenClawModelsJson } from "./models-config.js";
 import { readGeneratedModelsJson } from "./models-config.test-utils.js";
 
+function createGoogleModelsConfig(
+  models: NonNullable<OpenClawConfig["models"]>["providers"]["google"]["models"],
+): OpenClawConfig {
+  return {
+    models: {
+      providers: {
+        google: {
+          baseUrl: "https://generativelanguage.googleapis.com/v1beta",
+          apiKey: "GEMINI_KEY", // pragma: allowlist secret
+          api: "google-generative-ai",
+          models,
+        },
+      },
+    },
+  };
+}
+
+async function expectGeneratedGoogleModelIds(ids: string[]) {
+  const parsed = await readGeneratedModelsJson<{
+    providers: Record<string, { models: Array<{ id: string }> }>;
+  }>();
+  expect(parsed.providers.google?.models?.map((model) => model.id)).toEqual(ids);
+}
+
 describe("models-config", () => {
   installModelsConfigTestHooks();
 
   it("normalizes gemini 3 ids to preview for google providers", async () => {
     await withModelsTempHome(async () => {
-      const cfg: OpenClawConfig = {
-        models: {
-          providers: {
-            google: {
-              baseUrl: "https://generativelanguage.googleapis.com/v1beta",
-              apiKey: "GEMINI_KEY", // pragma: allowlist secret
-              api: "google-generative-ai",
-              models: [
-                {
-                  id: "gemini-3-pro",
-                  name: "Gemini 3 Pro",
-                  api: "google-generative-ai",
-                  reasoning: true,
-                  input: ["text", "image"],
-                  cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 },
-                  contextWindow: 1048576,
-                  maxTokens: 65536,
-                },
-                {
-                  id: "gemini-3-flash",
-                  name: "Gemini 3 Flash",
-                  api: "google-generative-ai",
-                  reasoning: false,
-                  input: ["text", "image"],
-                  cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 },
-                  contextWindow: 1048576,
-                  maxTokens: 65536,
-                },
-              ],
-            },
-          },
+      const cfg = createGoogleModelsConfig([
+        {
+          id: "gemini-3-pro",
+          name: "Gemini 3 Pro",
+          api: "google-generative-ai",
+          reasoning: true,
+          input: ["text", "image"],
+          cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 },
+          contextWindow: 1048576,
+          maxTokens: 65536,
         },
-      };
+        {
+          id: "gemini-3-flash",
+          name: "Gemini 3 Flash",
+          api: "google-generative-ai",
+          reasoning: false,
+          input: ["text", "image"],
+          cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 },
+          contextWindow: 1048576,
+          maxTokens: 65536,
+        },
+      ]);
 
       await ensureOpenClawModelsJson(cfg);
-
-      const parsed = await readGeneratedModelsJson<{
-        providers: Record<string, { models: Array<{ id: string }> }>;
-      }>();
-      const ids = parsed.providers.google?.models?.map((model) => model.id);
-      expect(ids).toEqual(["gemini-3-pro-preview", "gemini-3-flash-preview"]);
+      await expectGeneratedGoogleModelIds(["gemini-3-pro-preview", "gemini-3-flash-preview"]);
     });
   });
 
   it("normalizes the deprecated google flash preview id to the working preview id", async () => {
     await withModelsTempHome(async () => {
-      const cfg: OpenClawConfig = {
-        models: {
-          providers: {
-            google: {
-              baseUrl: "https://generativelanguage.googleapis.com/v1beta",
-              apiKey: "GEMINI_KEY", // pragma: allowlist secret
-              api: "google-generative-ai",
-              models: [
-                {
-                  id: "gemini-3.1-flash-preview",
-                  name: "Gemini 3.1 Flash Preview",
-                  api: "google-generative-ai",
-                  reasoning: false,
-                  input: ["text", "image"],
-                  cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 },
-                  contextWindow: 1048576,
-                  maxTokens: 65536,
-                },
-              ],
-            },
-          },
+      const cfg = createGoogleModelsConfig([
+        {
+          id: "gemini-3.1-flash-preview",
+          name: "Gemini 3.1 Flash Preview",
+          api: "google-generative-ai",
+          reasoning: false,
+          input: ["text", "image"],
+          cost: { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 },
+          contextWindow: 1048576,
+          maxTokens: 65536,
         },
-      };
+      ]);
 
       await ensureOpenClawModelsJson(cfg);
-
-      const parsed = await readGeneratedModelsJson<{
-        providers: Record<string, { models: Array<{ id: string }> }>;
-      }>();
-      const ids = parsed.providers.google?.models?.map((model) => model.id);
-      expect(ids).toEqual(["gemini-3-flash-preview"]);
+      await expectGeneratedGoogleModelIds(["gemini-3-flash-preview"]);
     });
   });
 });